From: Richard Cochran <richardcochran@gmail.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: davem@davemloft.net, tony@atomide.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: clk dereference in drivers/net/ethernet/ti/cpts.c
Date: Thu, 3 Jan 2013 15:00:00 +0100 [thread overview]
Message-ID: <20130103140000.GA9656@localhost.localdomain> (raw)
In-Reply-To: <alpine.DEB.2.02.1301031040320.1989@hadrien>
On Thu, Jan 03, 2013 at 11:20:52AM +0100, Julia Lawall wrote:
> There has been a discussion recently about how the result of get_clk
> should be an opaque handle, not a value that can be dereferenced:
>
> https://lkml.org/lkml/2012/12/20/105
>
> There is such a dereference in drivers/net/ethernet/ti/cpts.c, in the
> function cpts_clk_init:
>
> cpts->freq = cpts->refclk->recalc(cpts->refclk);
>
> It was not obvious to me, however, what API function should be used
> instead, so I am just reporting the (potential) problem.
This issue has been fixed in v3.8-rc2.
Thanks,
Richard
prev parent reply other threads:[~2013-01-03 14:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-03 10:20 clk dereference in drivers/net/ethernet/ti/cpts.c Julia Lawall
2013-01-03 14:00 ` Richard Cochran [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130103140000.GA9656@localhost.localdomain \
--to=richardcochran@gmail.com \
--cc=davem@davemloft.net \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).