* clk dereference in drivers/net/ethernet/ti/cpts.c
@ 2013-01-03 10:20 Julia Lawall
2013-01-03 14:00 ` Richard Cochran
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2013-01-03 10:20 UTC (permalink / raw)
To: davem, richardcochran, tony, netdev, linux-kernel
There has been a discussion recently about how the result of get_clk
should be an opaque handle, not a value that can be dereferenced:
https://lkml.org/lkml/2012/12/20/105
There is such a dereference in drivers/net/ethernet/ti/cpts.c, in the
function cpts_clk_init:
cpts->freq = cpts->refclk->recalc(cpts->refclk);
It was not obvious to me, however, what API function should be used
instead, so I am just reporting the (potential) problem.
thanks,
julia
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: clk dereference in drivers/net/ethernet/ti/cpts.c
2013-01-03 10:20 clk dereference in drivers/net/ethernet/ti/cpts.c Julia Lawall
@ 2013-01-03 14:00 ` Richard Cochran
0 siblings, 0 replies; 2+ messages in thread
From: Richard Cochran @ 2013-01-03 14:00 UTC (permalink / raw)
To: Julia Lawall; +Cc: davem, tony, netdev, linux-kernel
On Thu, Jan 03, 2013 at 11:20:52AM +0100, Julia Lawall wrote:
> There has been a discussion recently about how the result of get_clk
> should be an opaque handle, not a value that can be dereferenced:
>
> https://lkml.org/lkml/2012/12/20/105
>
> There is such a dereference in drivers/net/ethernet/ti/cpts.c, in the
> function cpts_clk_init:
>
> cpts->freq = cpts->refclk->recalc(cpts->refclk);
>
> It was not obvious to me, however, what API function should be used
> instead, so I am just reporting the (potential) problem.
This issue has been fixed in v3.8-rc2.
Thanks,
Richard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-03 14:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-03 10:20 clk dereference in drivers/net/ethernet/ti/cpts.c Julia Lawall
2013-01-03 14:00 ` Richard Cochran
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).