From: Dave Jones <davej@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org, h.reindl@thelounge.net,
Fedora Kernel Team <kernel-team@fedoraproject.org>
Subject: Re: order 7 allocations from xt_recent
Date: Thu, 3 Jan 2013 12:11:15 -0500 [thread overview]
Message-ID: <20130103171115.GA20982@redhat.com> (raw)
In-Reply-To: <1357232104.21409.25175.camel@edumazet-glaptop>
On Thu, Jan 03, 2013 at 08:55:04AM -0800, Eric Dumazet wrote:
> On Thu, 2013-01-03 at 11:43 -0500, Dave Jones wrote:
> > We had a report from a user that shows this code trying
> > to do enormous allocations, which isn't going to work too well..
> > ...
> > Which is initialised thus..
> >
> > ip_list_hash_size = 1 << fls(ip_list_tot);
> >
> > And ip_list_tot is 10000 in this case. Hmm ?
> >
> > Complete report and setup described in his bug report at https://bugzilla.redhat.com/show_bug.cgi?id=890715
>
> Yes, we had a report and a patch :
>
> http://comments.gmane.org/gmane.linux.network/248216
>
> I'll send it in a more formal way.
Ah! Excellent.
That 'check size and vmalloc/kmalloc accordingly' thing seems to be a pattern
that comes up time and time again. Is it worth maybe making a more generic
version of that instead of open-coding it each time it comes up ?
thanks,
Dave
next prev parent reply other threads:[~2013-01-03 17:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-03 16:43 order 7 allocations from xt_recent Dave Jones
2013-01-03 16:55 ` Eric Dumazet
2013-01-03 17:11 ` Dave Jones [this message]
2013-01-03 17:26 ` Dave Jones
2013-01-03 18:00 ` Eric Dumazet
2013-01-03 19:51 ` Reindl Harald
2013-01-03 18:02 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130103171115.GA20982@redhat.com \
--to=davej@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=h.reindl@thelounge.net \
--cc=kernel-team@fedoraproject.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).