From: David Miller <davem@davemloft.net>
To: lkundrak@v3.sk
Cc: buytenh@wantstofly.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mv643xx_eth: Fix a possible deadlock upon ifdown
Date: Fri, 04 Jan 2013 15:20:31 -0800 (PST) [thread overview]
Message-ID: <20130104.152031.1827815520394695268.davem@davemloft.net> (raw)
In-Reply-To: <1357309063-20236-1-git-send-email-lkundrak@v3.sk>
From: Lubomir Rintel <lkundrak@v3.sk>
Date: Fri, 4 Jan 2013 15:17:43 +0100
> @@ -943,7 +943,7 @@ static int txq_reclaim(struct tx_queue *txq, int budget, int force)
> struct netdev_queue *nq = netdev_get_tx_queue(mp->dev, txq->index);
> int reclaimed;
>
> - __netif_tx_lock(nq, smp_processor_id());
> + __netif_tx_lock_bh(nq);
I still don't understand why this change is necessary.
The TX reclaim function is invoked in software interrupt context in
all of the places where this lockdep warning might matter.
next prev parent reply other threads:[~2013-01-04 23:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-04 14:07 [PATCH] mv643xx_eth: Fix a possible deadlock upon ifdown Lubomir Rintel
2013-01-04 14:17 ` Lubomir Rintel
2013-01-04 23:20 ` David Miller [this message]
2013-01-04 20:25 ` Lennert Buytenhek
2013-03-01 17:30 ` Alexander Holler
2013-03-12 2:49 ` Lennert Buytenhek
2013-03-12 9:04 ` Alexander Holler
2013-03-12 11:36 ` Alexander Holler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130104.152031.1827815520394695268.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=buytenh@wantstofly.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).