From: David Miller <davem@davemloft.net>
To: jiri@resnulli.us
Cc: netdev@vger.kernel.org, edumazet@google.com,
bhutchings@solarflare.com, shemminger@vyatta.com, fbl@redhat.com,
sathya.perla@emulex.com, subbu.seetharaman@emulex.com,
ajit.khaparde@emulex.com, roland@kernel.org,
sean.hefty@intel.com, hal.rosenstock@gmail.com,
ursula.braun@de.ibm.com, blaschka@linux.vnet.ibm.com,
linux390@de.ibm.com
Subject: Re: [patch net-next V2] ethtool: fix drvinfo strings set in drivers
Date: Sun, 06 Jan 2013 21:06:55 -0800 (PST) [thread overview]
Message-ID: <20130106.210655.1262628911724067629.davem@davemloft.net> (raw)
In-Reply-To: <1357469066-10620-1-git-send-email-jiri@resnulli.us>
From: Jiri Pirko <jiri@resnulli.us>
Date: Sun, 6 Jan 2013 11:44:26 +0100
> Use strlcpy where possible to ensure the string is \0 terminated.
> Use always sizeof(string) instead of 32, ETHTOOL_BUSINFO_LEN
> and custom defines.
> Use snprintf instead of sprint.
> Remove unnecessary inits of ->fw_version
> Remove unnecessary inits of drvinfo struct.
>
> Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Applied.
prev parent reply other threads:[~2013-01-07 5:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-06 10:44 [patch net-next V2] ethtool: fix drvinfo strings set in drivers Jiri Pirko
2013-01-07 5:06 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130106.210655.1262628911724067629.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ajit.khaparde@emulex.com \
--cc=bhutchings@solarflare.com \
--cc=blaschka@linux.vnet.ibm.com \
--cc=edumazet@google.com \
--cc=fbl@redhat.com \
--cc=hal.rosenstock@gmail.com \
--cc=jiri@resnulli.us \
--cc=linux390@de.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=roland@kernel.org \
--cc=sathya.perla@emulex.com \
--cc=sean.hefty@intel.com \
--cc=shemminger@vyatta.com \
--cc=subbu.seetharaman@emulex.com \
--cc=ursula.braun@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).