* [PATCH v2] net: fec: Place 'inline' in the beginning of declaration
@ 2013-01-08 3:29 Fabio Estevam
2013-01-08 3:35 ` Joe Perches
2013-01-08 3:36 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2013-01-08 3:29 UTC (permalink / raw)
To: davem; +Cc: shawn.guo, netdev, Fabio Estevam
From: Fabio Estevam <fabio.estevam@freescale.com>
Fix the following warning when building with W=1 option:
drivers/net/ethernet/freescale/fec.c:810:1: warning: '__inline__' is not at beginning of declaration [-Wold-style-declaration]
The inline declaration is pointless in this function, so just remove it.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
Changes since v1:
- Remove the 'inline'
drivers/net/ethernet/freescale/fec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/fec.c b/drivers/net/ethernet/freescale/fec.c
index a379319..69d6069 100644
--- a/drivers/net/ethernet/freescale/fec.c
+++ b/drivers/net/ethernet/freescale/fec.c
@@ -807,7 +807,7 @@ fec_enet_interrupt(int irq, void *dev_id)
/* ------------------------------------------------------------------------- */
-static void __inline__ fec_get_mac(struct net_device *ndev)
+static void fec_get_mac(struct net_device *ndev)
{
struct fec_enet_private *fep = netdev_priv(ndev);
struct fec_platform_data *pdata = fep->pdev->dev.platform_data;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] net: fec: Place 'inline' in the beginning of declaration
2013-01-08 3:29 [PATCH v2] net: fec: Place 'inline' in the beginning of declaration Fabio Estevam
@ 2013-01-08 3:35 ` Joe Perches
2013-01-08 3:36 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Joe Perches @ 2013-01-08 3:35 UTC (permalink / raw)
To: Fabio Estevam; +Cc: davem, shawn.guo, netdev, Fabio Estevam
On Tue, 2013-01-08 at 01:29 -0200, Fabio Estevam wrote:
> The inline declaration is pointless in this function, so just remove it.
Perhaps remove all 3 inlines from the file at the same time.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] net: fec: Place 'inline' in the beginning of declaration
2013-01-08 3:29 [PATCH v2] net: fec: Place 'inline' in the beginning of declaration Fabio Estevam
2013-01-08 3:35 ` Joe Perches
@ 2013-01-08 3:36 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2013-01-08 3:36 UTC (permalink / raw)
To: festevam; +Cc: shawn.guo, netdev, fabio.estevam
Are you really too lazy to update the Subject line?
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-08 3:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-08 3:29 [PATCH v2] net: fec: Place 'inline' in the beginning of declaration Fabio Estevam
2013-01-08 3:35 ` Joe Perches
2013-01-08 3:36 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).