From: David Miller <davem@davemloft.net>
To: zajec5@gmail.com
Cc: netdev@vger.kernel.org, romieu@fr.zoreil.com, joe@perches.com
Subject: Re: [PATCH V4] bgmac: driver for GBit MAC core on BCMA bus
Date: Mon, 07 Jan 2013 22:21:52 -0800 (PST) [thread overview]
Message-ID: <20130107.222152.1296444483411794560.davem@davemloft.net> (raw)
In-Reply-To: <CACna6rxknwzwvrZZp5++10-ZLLjUf2TMuO7d7vzxqJM2nxtckA@mail.gmail.com>
From: Rafał Miłecki <zajec5@gmail.com>
Date: Tue, 8 Jan 2013 06:51:13 +0100
> 2013/1/8 David Miller <davem@davemloft.net>:
>> From: Rafał Miłecki <zajec5@gmail.com>
>> Date: Sun, 6 Jan 2013 01:20:09 +0100
>>
>>> V4: stop queue when ring is full
>>
>> You're still not doing it right.
>>
>>> + if (free_slots == 1) { /* Should never happen (netif_stop_queue) */
>>> + bgmac_err(bgmac, "TX after stopping queue!\n");
>>> + return NETDEV_TX_BUSY;
>>> + }
>>
>> You need to call netif_stop_queue() in this code path too.
>
> In case of (free_slots == 1) the queue should already be stopped by
> the previous xmit call (at the end). I didn't know it make sens to try
> stopping it again.
It obviously is not stopped, otherwise this function wouldn't get
called.
prev parent reply other threads:[~2013-01-08 6:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-06 0:20 [PATCH V4] bgmac: driver for GBit MAC core on BCMA bus Rafał Miłecki
2013-01-08 3:40 ` David Miller
2013-01-08 5:51 ` Rafał Miłecki
2013-01-08 6:21 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130107.222152.1296444483411794560.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).