From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Cooper Subject: Re: [PATCH 3.8-rc] net: mvneta: fix driver operation in SMP context Date: Mon, 7 Jan 2013 11:44:15 -0500 Message-ID: <20130107164415.GI5075@titan.lakedaemon.net> References: <1357576074-24245-1-git-send-email-thomas.petazzoni@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "David S. Miller" , Lior Amsalem , Andrew Lunn , netdev@vger.kernel.org, Maen Suleiman , Gregory Clement , Dmitri Epshtein , linux-arm-kernel@lists.infradead.org To: Thomas Petazzoni Return-path: Received: from mho-03-ewr.mailhop.org ([204.13.248.66]:40120 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753805Ab3AGQo0 (ORCPT ); Mon, 7 Jan 2013 11:44:26 -0500 Content-Disposition: inline In-Reply-To: <1357576074-24245-1-git-send-email-thomas.petazzoni@free-electrons.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Jan 07, 2013 at 05:27:54PM +0100, Thomas Petazzoni wrote: > From: Dmitri Epshtein > > In order for the driver to behave properly in a SMP context, the same > transmit queue should be used by the kernel in dev_queue_xmit() and in > the driver's mvneta_tx() function. To achieve that, the driver now > implements the ->ndo_select_txq() operation. > > For now, it always returns the same transmit queue, txq_def, until the > driver is expanded to properly take advantage of the multiqueue > capabilities of the hardware. > > Without this patch, the network driver crashes the kernel almost > immediately on Armada XP platforms, if the network load is at least a > little bit parallel (i.e several threads). > > [Thomas Petazzoni: reword commit message] > Signed-off-by: Dmitri Epshtein > Signed-off-by: Thomas Petazzoni Acked-by: Jason Cooper I'll assume this is going through -net, let me know if it should be otherwise. thx, Jason.