From: Flavio Leitner <fbl@redhat.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
bhutchings@solarflare.com, richardcochran@gmail.com,
greearb@candelatech.com, jeffrey.t.kirsher@intel.com
Subject: Re: [patch net-next v2] ethtool: consolidate work with ethtool_ops
Date: Mon, 7 Jan 2013 18:06:56 -0200 [thread overview]
Message-ID: <20130107200656.GA2090@obelix.rh> (raw)
In-Reply-To: <1357585328-3405-1-git-send-email-jiri@resnulli.us>
On Mon, Jan 07, 2013 at 08:02:08PM +0100, Jiri Pirko wrote:
> No need to check if ethtool_ops == NULL since it can't be.
> Use local variable "ops" in functions where it is present
> instead of dev->ethtool_ops
> Introduce local variable "ops" in functions where dev->ethtool_ops is used
> many times.
>
> Signed-off-by: Jiri Pirko <jiri@resnulli.us>
> ---
Reviewed-by: Flavio Leitner <fbl@redhat.com>
next prev parent reply other threads:[~2013-01-07 20:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-07 19:02 [patch net-next v2] ethtool: consolidate work with ethtool_ops Jiri Pirko
2013-01-07 19:42 ` Ben Hutchings
2013-01-07 20:06 ` Flavio Leitner [this message]
2013-01-08 3:54 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130107200656.GA2090@obelix.rh \
--to=fbl@redhat.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=greearb@candelatech.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).