From: David Miller <davem@davemloft.net>
To: jiri@resnulli.us
Cc: netdev@vger.kernel.org, edumazet@google.com,
shemminger@vyatta.com, kuznet@ms2.inr.ac.ru, jmorris@namei.org,
yoshfuji@linux-ipv6.org, kaber@trash.net
Subject: Re: [RFC patch net-next] ipv4: use bcast as dst address in case IFF_NOARP is set
Date: Tue, 08 Jan 2013 14:27:37 -0800 (PST) [thread overview]
Message-ID: <20130108.142737.1239088077093843462.davem@davemloft.net> (raw)
In-Reply-To: <1357650162-5554-1-git-send-email-jiri@resnulli.us>
From: Jiri Pirko <jiri@resnulli.us>
Date: Tue, 8 Jan 2013 14:02:42 +0100
> When IFF_NOARP is set on a device, dev->dev_addr is used as *dst*
> addr of sent frames. That does not make sense. Use rather bcast address
> instead.
>
> Signed-off-by: Jiri Pirko <jiri@resnulli.us>
The address is actually arbitrary in this case, I believe the
current behavior is intentional, and even if it is not intentional
since the address is arbitrary this change carrys only potential
risk for zero gain.
prev parent reply other threads:[~2013-01-08 22:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-08 13:02 [RFC patch net-next] ipv4: use bcast as dst address in case IFF_NOARP is set Jiri Pirko
2013-01-08 17:11 ` Stephen Hemminger
2013-01-08 17:45 ` Jiri Pirko
2013-01-08 19:10 ` Stephen Hemminger
2013-01-08 21:51 ` Jan Engelhardt
2013-01-08 22:33 ` David Miller
2013-01-08 22:27 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130108.142737.1239088077093843462.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).