[PATCH 0/5] ipv4_tunnels: Modularize ipv4 tunneling.

[PATCH 0/5] ipv4_tunnels: Modularize ipv4 tunneling.

[Pravin B Shelar]

From: Pravin Shelar <pshelar@nicira.com>

Following patch series restructure GRE and IPIP tunneling code
to make it modular. It adds ip_tunnel module which acts as
generic tunneling layer which has common code. I have patch
to do same for VXLAN too.

In Addidtion to restructuring it adds demultiplexer for ipgre
protocol, so that linux kernel IPGRE module and OVS gre module
can co-exist.
Last patch adds linux state updates to tunnel device from
lower device.

Pravin Shelar (5):
  GRE: Add segmentation offload for GRE TAP device.
  GRE: Use RTNL for atomic protocol registration.
  GRE: Refactor code GRE code.
  IPIP: Use ip-tunneling code.
  IP_TUNNEL: follow state of lower device

 drivers/net/ppp/pptp.c    |    4 +
 include/linux/if_tunnel.h |    8 -
 include/linux/skbuff.h    |   12 +
 include/net/gre.h         |   57 ++
 include/net/ip_tunnel.h   |  164 +++++
 include/net/ipip.h        |   74 ---
 net/ipv4/Kconfig          |    6 +
 net/ipv4/Makefile         |    1 +
 net/ipv4/af_inet.c        |    2 +-
 net/ipv4/gre.c            |  496 ++++++++++++++-
 net/ipv4/ip_gre.c         | 1569 ++++++++-------------------------------------
 net/ipv4/ip_tunnel.c      | 1171 +++++++++++++++++++++++++++++++++
 net/ipv4/ip_vti.c         |    2 +-
 net/ipv4/ipip.c           |  780 +++--------------------
 net/ipv4/ipmr.c           |    2 +-
 net/ipv4/tcp.c            |    1 +
 net/ipv4/udp.c            |    3 +-
 net/ipv6/af_inet6.c       |    1 -
 net/ipv6/ip6_gre.c        |    1 +
 net/ipv6/ip6_offload.c    |    1 +
 net/ipv6/ip6_tunnel.c     |    1 +
 net/ipv6/sit.c            |    2 +-
 net/ipv6/udp_offload.c    |    3 +-
 23 files changed, 2268 insertions(+), 2093 deletions(-)
 create mode 100644 include/net/ip_tunnel.h
 delete mode 100644 include/net/ipip.h
 create mode 100644 net/ipv4/ip_tunnel.c

Re: [PATCH 0/5] ipv4_tunnels: Modularize ipv4 tunneling.

[Or Gerlitz]

On Tue, Jan 8, 2013 at 4:31 AM, Pravin B Shelar <pshelar@nicira.com> wrote:
> Following patch series restructure GRE and IPIP tunneling code
> to make it modular. It adds ip_tunnel module which acts as
> generic tunneling layer which has common code. I have patch
> to do same for VXLAN too. [..]

Can you be more specific re the vxlan patch?

Or.

Re: [PATCH 0/5] ipv4_tunnels: Modularize ipv4 tunneling.

[Pravin Shelar]

[-- Attachment #1.1: Type: text/plain, Size: 659 bytes --]

On Tue, Jan 8, 2013 at 1:10 PM, Or Gerlitz <or.gerlitz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:

> On Tue, Jan 8, 2013 at 4:31 AM, Pravin B Shelar <pshelar-l0M0P4e3n4LQT0dZR+AlfA@public.gmane.org>
> wrote:
> > Following patch series restructure GRE and IPIP tunneling code
> > to make it modular. It adds ip_tunnel module which acts as
> > generic tunneling layer which has common code. I have patch
> > to do same for VXLAN too. [..]
>
> Can you be more specific re the vxlan patch?
>
>
I am in process of updating VXLAN patches, I will send new version soon. I
have earlier version posted on openvswitch dev mailing list last month.

Thanks,
Pravin.

[-- Attachment #1.2: Type: text/html, Size: 1254 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: [PATCH 0/5] ipv4_tunnels: Modularize ipv4 tunneling.

[Pravin Shelar]

On Tue, Jan 8, 2013 at 1:10 PM, Or Gerlitz <or.gerlitz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> On Tue, Jan 8, 2013 at 4:31 AM, Pravin B Shelar <pshelar-l0M0P4e3n4LQT0dZR+AlfA@public.gmane.org> wrote:
>> Following patch series restructure GRE and IPIP tunneling code
>> to make it modular. It adds ip_tunnel module which acts as
>> generic tunneling layer which has common code. I have patch
>> to do same for VXLAN too. [..]
>
> Can you be more specific re the vxlan patch?
>

I am in process of updating VXLAN patches, I will send new version
soon. I have earlier version posted on openvswitch dev mailing list
last month.

Thanks,
Pravin.

Re: [PATCH 0/5] ipv4_tunnels: Modularize ipv4 tunneling.

[David Miller]

From: Pravin B Shelar <pshelar@nicira.com>
Date: Mon,  7 Jan 2013 18:31:32 -0800

> Following patch series restructure GRE and IPIP tunneling code
> to make it modular. It adds ip_tunnel module which acts as
> generic tunneling layer which has common code. I have patch
> to do same for VXLAN too.
> 
> In Addidtion to restructuring it adds demultiplexer for ipgre
> protocol, so that linux kernel IPGRE module and OVS gre module
> can co-exist.
> Last patch adds linux state updates to tunnel device from
> lower device.

Please resubmit this when you can also submit the patches which
actually use this new modularity.

Otherwise the value proposition is impossible to analyze.

Thanks.

Re: [PATCH 0/5] ipv4_tunnels: Modularize ipv4 tunneling.

[Pravin Shelar]

On Wed, Jan 9, 2013 at 11:52 PM, David Miller <davem@davemloft.net> wrote:
> From: Pravin B Shelar <pshelar@nicira.com>
> Date: Mon,  7 Jan 2013 18:31:32 -0800
>
>> Following patch series restructure GRE and IPIP tunneling code
>> to make it modular. It adds ip_tunnel module which acts as
>> generic tunneling layer which has common code. I have patch
>> to do same for VXLAN too.
>>
>> In Addidtion to restructuring it adds demultiplexer for ipgre
>> protocol, so that linux kernel IPGRE module and OVS gre module
>> can co-exist.
>> Last patch adds linux state updates to tunnel device from
>> lower device.
>
> Please resubmit this when you can also submit the patches which
> actually use this new modularity.
>
> Otherwise the value proposition is impossible to analyze.
>
Ok. These patches are not just modularize ipv4 tunnels but also does
code refactoring, so that there is less code duplication in different
tunneling implementation.

There are couple of independent patches from this patch series. I will
submit them separately. Later I will resubmit modular ip-tunnel
patches as you have suggested.

Thanks,
Pravin.