[patch] bnx2x: NULL dereference on error in debug code

netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [patch] bnx2x: NULL dereference on error in debug code
@ 2013-01-08 13:42 Dan Carpenter
  2013-01-08 14:50 ` Ariel Elior
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Dan Carpenter @ 2013-01-08 13:42 UTC (permalink / raw)
  To: Eilon Greenstein; +Cc: netdev, linux-kernel, kernel-janitors

"vfop" is NULL here.  I've changed the debugging to not use it.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Only needed in linux-next.

diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
index 71fcef0..3eef972 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
@@ -463,8 +463,7 @@ static int bnx2x_vfop_qdtor_cmd(struct bnx2x *bp,
 		return bnx2x_vfop_transition(bp, vf, bnx2x_vfop_qdtor,
 					     cmd->block);
 	}
-	DP(BNX2X_MSG_IOV, "VF[%d] failed to add a vfop. rc %d\n",
-	   vf->abs_vfid, vfop->rc);
+	DP(BNX2X_MSG_IOV, "VF[%d] failed to add a vfop.\n", vf->abs_vfid);
 	return -ENOMEM;
 }
 

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* RE: [patch] bnx2x: NULL dereference on error in debug code
  2013-01-08 13:42 [patch] bnx2x: NULL dereference on error in debug code Dan Carpenter
@ 2013-01-08 14:50 ` Ariel Elior
  2013-01-08 22:30   ` David Miller
  2013-01-08 14:54 ` Ariel Elior
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 6+ messages in thread
From: Ariel Elior @ 2013-01-08 14:50 UTC (permalink / raw)
  To: Dan Carpenter, Eilon Greenstein
  Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org

> -----Original Message-----
> From: netdev-owner@vger.kernel.org [mailto:netdev-
> owner@vger.kernel.org] On Behalf Of Dan Carpenter
> Sent: Tuesday, January 08, 2013 3:42 PM
> To: Eilon Greenstein
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; kernel-
> janitors@vger.kernel.org
> Subject: [patch] bnx2x: NULL dereference on error in debug code
> 
> "vfop" is NULL here.  I've changed the debugging to not use it.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Only needed in linux-next.
> 
> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
> b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
> index 71fcef0..3eef972 100644
> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
> @@ -463,8 +463,7 @@ static int bnx2x_vfop_qdtor_cmd(struct bnx2x *bp,
>  		return bnx2x_vfop_transition(bp, vf, bnx2x_vfop_qdtor,
>  					     cmd->block);
>  	}
> -	DP(BNX2X_MSG_IOV, "VF[%d] failed to add a vfop. rc %d\n",
> -	   vf->abs_vfid, vfop->rc);
> +	DP(BNX2X_MSG_IOV, "VF[%d] failed to add a vfop.\n", vf->abs_vfid);
>  	return -ENOMEM;
>  }
> 
Right you are. Ack.
Thanks Dan,
Ariel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [patch] bnx2x: NULL dereference on error in debug code
  2013-01-08 14:50 ` Ariel Elior
@ 2013-01-08 22:30   ` David Miller
  0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2013-01-08 22:30 UTC (permalink / raw)
  To: ariele; +Cc: dan.carpenter, eilong, netdev, linux-kernel, kernel-janitors

From: "Ariel Elior" <ariele@broadcom.com>
Date: Tue, 8 Jan 2013 14:50:50 +0000

>> -----Original Message-----
>> From: netdev-owner@vger.kernel.org [mailto:netdev-
>> owner@vger.kernel.org] On Behalf Of Dan Carpenter
>> Sent: Tuesday, January 08, 2013 3:42 PM
>> To: Eilon Greenstein
>> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; kernel-
>> janitors@vger.kernel.org
>> Subject: [patch] bnx2x: NULL dereference on error in debug code
>> 
>> "vfop" is NULL here.  I've changed the debugging to not use it.
>> 
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>> ---
>> Only needed in linux-next.
>> 
>> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
>> b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
>> index 71fcef0..3eef972 100644
>> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
>> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
>> @@ -463,8 +463,7 @@ static int bnx2x_vfop_qdtor_cmd(struct bnx2x *bp,
>>  		return bnx2x_vfop_transition(bp, vf, bnx2x_vfop_qdtor,
>>  					     cmd->block);
>>  	}
>> -	DP(BNX2X_MSG_IOV, "VF[%d] failed to add a vfop. rc %d\n",
>> -	   vf->abs_vfid, vfop->rc);
>> +	DP(BNX2X_MSG_IOV, "VF[%d] failed to add a vfop.\n", vf->abs_vfid);
>>  	return -ENOMEM;
>>  }
>> 
> Right you are. Ack.

This is not the correct way to ack a patch, this is:

Acked-by: Ariel Elior <ariele@broadcom.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: [patch] bnx2x: NULL dereference on error in debug code
  2013-01-08 13:42 [patch] bnx2x: NULL dereference on error in debug code Dan Carpenter
  2013-01-08 14:50 ` Ariel Elior
@ 2013-01-08 14:54 ` Ariel Elior
  2013-01-09  7:38 ` Ariel Elior
  2013-01-10  7:53 ` David Miller
  3 siblings, 0 replies; 6+ messages in thread
From: Ariel Elior @ 2013-01-08 14:54 UTC (permalink / raw)
  To: Dan Carpenter, Eilon Greenstein
  Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org

> -----Original Message-----
> From: netdev-owner@vger.kernel.org [mailto:netdev-
> owner@vger.kernel.org] On Behalf Of Dan Carpenter
> Sent: Tuesday, January 08, 2013 3:42 PM
> To: Eilon Greenstein
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; kernel-
> janitors@vger.kernel.org
> Subject: [patch] bnx2x: NULL dereference on error in debug code
> 
> "vfop" is NULL here.  I've changed the debugging to not use it.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Only needed in linux-next.
> 
> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
> b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
> index 71fcef0..3eef972 100644
> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
> @@ -463,8 +463,7 @@ static int bnx2x_vfop_qdtor_cmd(struct bnx2x *bp,
>  		return bnx2x_vfop_transition(bp, vf, bnx2x_vfop_qdtor,
>  					     cmd->block);
>  	}
> -	DP(BNX2X_MSG_IOV, "VF[%d] failed to add a vfop. rc %d\n",
> -	   vf->abs_vfid, vfop->rc);
> +	DP(BNX2X_MSG_IOV, "VF[%d] failed to add a vfop.\n", vf->abs_vfid);
>  	return -ENOMEM;
>  }
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

And now acking it properly.
Acked-by Ariel Elior <ariele@broadcom.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: [patch] bnx2x: NULL dereference on error in debug code
  2013-01-08 13:42 [patch] bnx2x: NULL dereference on error in debug code Dan Carpenter
  2013-01-08 14:50 ` Ariel Elior
  2013-01-08 14:54 ` Ariel Elior
@ 2013-01-09  7:38 ` Ariel Elior
  2013-01-10  7:53 ` David Miller
  3 siblings, 0 replies; 6+ messages in thread
From: Ariel Elior @ 2013-01-09  7:38 UTC (permalink / raw)
  To: Dan Carpenter, Eilon Greenstein
  Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org

> -----Original Message-----
> From: netdev-owner@vger.kernel.org [mailto:netdev-
> owner@vger.kernel.org] On Behalf Of Dan Carpenter
> Sent: Tuesday, January 08, 2013 3:42 PM
> To: Eilon Greenstein
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; kernel-
> janitors@vger.kernel.org
> Subject: [patch] bnx2x: NULL dereference on error in debug code
> 
> "vfop" is NULL here.  I've changed the debugging to not use it.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Only needed in linux-next.
> 
> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
> b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
> index 71fcef0..3eef972 100644
> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
> @@ -463,8 +463,7 @@ static int bnx2x_vfop_qdtor_cmd(struct bnx2x *bp,
>  		return bnx2x_vfop_transition(bp, vf, bnx2x_vfop_qdtor,
>  					     cmd->block);
>  	}
> -	DP(BNX2X_MSG_IOV, "VF[%d] failed to add a vfop. rc %d\n",
> -	   vf->abs_vfid, vfop->rc);
> +	DP(BNX2X_MSG_IOV, "VF[%d] failed to add a vfop.\n", vf->abs_vfid);
>  	return -ENOMEM;
>  }
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
Acked-by: Ariel Elior <ariele@broadcom.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [patch] bnx2x: NULL dereference on error in debug code
  2013-01-08 13:42 [patch] bnx2x: NULL dereference on error in debug code Dan Carpenter
                   ` (2 preceding siblings ...)
  2013-01-09  7:38 ` Ariel Elior
@ 2013-01-10  7:53 ` David Miller
  3 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2013-01-10  7:53 UTC (permalink / raw)
  To: dan.carpenter; +Cc: eilong, netdev, linux-kernel, kernel-janitors

From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 8 Jan 2013 16:42:14 +0300

> "vfop" is NULL here.  I've changed the debugging to not use it.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied, thanks Dan.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2013-01-10  7:53 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-08 13:42 [patch] bnx2x: NULL dereference on error in debug code Dan Carpenter
2013-01-08 14:50 ` Ariel Elior
2013-01-08 22:30   ` David Miller
2013-01-08 14:54 ` Ariel Elior
2013-01-09  7:38 ` Ariel Elior
2013-01-10  7:53 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).