From: David Miller <davem@davemloft.net>
To: sgruszka@redhat.com
Cc: netdev@vger.kernel.org, edumazet@google.com,
greearb@candelatech.com, bjorn@mork.no,
linux-wireless@vger.kernel.org, bhutchings@solarflare.com,
mirqus@gmail.com
Subject: Re: [PATCH v2] net: set default_ethtool_ops in register_netdevice
Date: Wed, 09 Jan 2013 23:57:38 -0800 (PST) [thread overview]
Message-ID: <20130109.235738.467651533138068641.davem@davemloft.net> (raw)
In-Reply-To: <20130108153850.GA10464@redhat.com>
From: Stanislaw Gruszka <sgruszka@redhat.com>
Date: Tue, 8 Jan 2013 16:38:51 +0100
> Since:
>
> commit 2c60db037034d27f8c636403355d52872da92f81
> Author: Eric Dumazet <edumazet@google.com>
> Date: Sun Sep 16 09:17:26 2012 +0000
>
> net: provide a default dev->ethtool_ops
>
> wireless core does not correctly assign ethtool_ops. In order to fix
> the problem, move assignement of default_ethtool_ops to
> register_netdevice(). This is safe because both register_netdevice()
> and dev_ethtool() are protected by RTNL lock.
>
> Patch is besed on hint of Michał Mirosław.
>
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
> Cc: stable@vger.kernel.org # 3.7+
> ---
> v1 -> v2: change order of default_ethtool_ops initialization to avoid
> the problem. Change the subject accordingly.
I don't understand this. Why is the assignment of default_ethtool_ops
at netdev allocation time not working? Is wireless really not using
alloc_netdev*()?
next prev parent reply other threads:[~2013-01-10 7:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-08 15:38 [PATCH v2] net: set default_ethtool_ops in register_netdevice Stanislaw Gruszka
2013-01-10 7:57 ` David Miller [this message]
2013-01-10 8:36 ` Stanislaw Gruszka
2013-01-10 10:07 ` David Miller
[not found] ` <20130110.020729.1358020934840866117.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2013-01-10 10:12 ` David Miller
[not found] ` <20130110.021202.232771737304117743.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2013-01-10 11:41 ` Johannes Berg
2013-01-10 21:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130109.235738.467651533138068641.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=bjorn@mork.no \
--cc=edumazet@google.com \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mirqus@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).