From: David Miller <davem@davemloft.net>
To: stefanha@redhat.com
Cc: mst@redhat.com, jasowang@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tun: avoid owner checks on IFF_ATTACH_QUEUE
Date: Thu, 10 Jan 2013 14:38:35 -0800 (PST) [thread overview]
Message-ID: <20130110.143835.2008690798301758570.davem@davemloft.net> (raw)
In-Reply-To: <20130110115503.GD30885@stefanha-thinkpad.redhat.com>
From: Stefan Hajnoczi <stefanha@redhat.com>
Date: Thu, 10 Jan 2013 12:55:03 +0100
> On Thu, Jan 10, 2013 at 01:31:08PM +0200, Michael S. Tsirkin wrote:
>> At the moment, we check owner when we enable queue in tun.
>> This seems redundant and will break some valid uses
>> where fd is passed around: I think TUNSETOWNER is there
>> to prevent others from attaching to a persistent device not
>> owned by them. Here the fd is already attached,
>> enabling/disabling queue is more like read/write.
>>
>> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>>
>> ---
>>
>> Note: this is unrelated to Stefan's bugfix.
>
> This should go into 3.8-rc.
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Applied.
next prev parent reply other threads:[~2013-01-10 22:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-10 11:31 [PATCH] tun: avoid owner checks on IFF_ATTACH_QUEUE Michael S. Tsirkin
2013-01-10 11:55 ` Stefan Hajnoczi
2013-01-10 22:38 ` David Miller [this message]
2013-01-10 14:08 ` Jason Wang
2013-01-10 14:19 ` Michael S. Tsirkin
2013-01-10 14:27 ` Jason Wang
2013-01-10 14:41 ` Michael S. Tsirkin
2013-01-10 14:47 ` Jason Wang
2013-01-10 15:10 ` Michael S. Tsirkin
2013-01-10 15:27 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130110.143835.2008690798301758570.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).