* [patch] bnx2x: move debugging code before the return
@ 2013-01-10 8:58 Dan Carpenter
2013-01-10 9:53 ` Ariel Elior
2013-01-10 22:39 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2013-01-10 8:58 UTC (permalink / raw)
To: Eilon Greenstein; +Cc: netdev, kernel-janitors
I move the return down a line after the debugging printk.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c
index 292634f..d7029c8 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c
@@ -2768,10 +2768,10 @@ static int bnx2x_set_rss_flags(struct bnx2x *bp, struct ethtool_rxnfc *info)
} else if ((info->flow_type == UDP_V6_FLOW) &&
(bp->rss_conf_obj.udp_rss_v6 != udp_rss_requested)) {
bp->rss_conf_obj.udp_rss_v6 = udp_rss_requested;
- return bnx2x_config_rss_pf(bp, &bp->rss_conf_obj, 0);
DP(BNX2X_MSG_ETHTOOL,
"rss re-configured, UDP 4-tupple %s\n",
udp_rss_requested ? "enabled" : "disabled");
+ return bnx2x_config_rss_pf(bp, &bp->rss_conf_obj, 0);
} else {
return 0;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [patch] bnx2x: move debugging code before the return
2013-01-10 8:58 [patch] bnx2x: move debugging code before the return Dan Carpenter
@ 2013-01-10 9:53 ` Ariel Elior
2013-01-10 22:39 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Ariel Elior @ 2013-01-10 9:53 UTC (permalink / raw)
To: Dan Carpenter, Eilon Greenstein
Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
> -----Original Message-----
> From: netdev-owner@vger.kernel.org [mailto:netdev-
> owner@vger.kernel.org] On Behalf Of Dan Carpenter
> Sent: Thursday, January 10, 2013 10:58 AM
> To: Eilon Greenstein
> Cc: netdev@vger.kernel.org; kernel-janitors@vger.kernel.org
> Subject: [patch] bnx2x: move debugging code before the return
>
> I move the return down a line after the debugging printk.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c
> b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c
> index 292634f..d7029c8 100644
> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c
> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c
> @@ -2768,10 +2768,10 @@ static int bnx2x_set_rss_flags(struct bnx2x *bp,
> struct ethtool_rxnfc *info)
> } else if ((info->flow_type == UDP_V6_FLOW) &&
> (bp->rss_conf_obj.udp_rss_v6 !=
> udp_rss_requested)) {
> bp->rss_conf_obj.udp_rss_v6 = udp_rss_requested;
> - return bnx2x_config_rss_pf(bp, &bp->rss_conf_obj,
> 0);
> DP(BNX2X_MSG_ETHTOOL,
> "rss re-configured, UDP 4-tupple %s\n",
> udp_rss_requested ? "enabled" : "disabled");
> + return bnx2x_config_rss_pf(bp, &bp->rss_conf_obj,
> 0);
> } else {
> return 0;
> }
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Thanks Dan.
Acked-by: Ariel Elior <ariele@broadcom.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch] bnx2x: move debugging code before the return
2013-01-10 8:58 [patch] bnx2x: move debugging code before the return Dan Carpenter
2013-01-10 9:53 ` Ariel Elior
@ 2013-01-10 22:39 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2013-01-10 22:39 UTC (permalink / raw)
To: dan.carpenter; +Cc: eilong, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Thu, 10 Jan 2013 11:58:07 +0300
> I move the return down a line after the debugging printk.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-10 22:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-10 8:58 [patch] bnx2x: move debugging code before the return Dan Carpenter
2013-01-10 9:53 ` Ariel Elior
2013-01-10 22:39 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).