netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: yoshfuji@linux-ipv6.org
Cc: r.kuntz@ipflavors.com, nicolas.dichtel@6wind.com,
	netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH 1/1] ipv6: use addrconf_get_prefix_route for prefix route lookup [v2]
Date: Thu, 10 Jan 2013 14:39:21 -0800 (PST)	[thread overview]
Message-ID: <20130110.143921.1060148433440698446.davem@davemloft.net> (raw)
In-Reply-To: <50EE8D79.1080807@linux-ipv6.org>

From: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Date: Thu, 10 Jan 2013 18:44:25 +0900

> Romain KUNTZ wrote:
> 
>> From 203474c87f45da40b5c9d9e629164561307b4199 Mon Sep 17 00:00:00 2001
>> From: Romain Kuntz <r.kuntz@ipflavors.com>
>> Date: Thu, 10 Jan 2013 07:41:36 +0100
>> Subject: [PATCH 1/1] ipv6: use addrconf_get_prefix_route for prefix route lookup [v2]
>> 
>> Replace ip6_route_lookup() with addrconf_get_prefix_route() when
>> looking up for a prefix route. This ensures that the connected prefix
>> is looked up in the main table, and avoids the selection of other
>> matching routes located in different tables as well as blackhole
>> or prohibited entries.
>> 
>> In addition, this fixes an Opps introduced by commit 64c6d08e (ipv6:
>> del unreachable route when an addr is deleted on lo), that would occur
>> when a blackhole or prohibited entry is selected by ip6_route_lookup().
>> Such entries have a NULL rt6i_table argument, which is accessed by
>> __ip6_del_rt() when trying to lock rt6i_table->tb6_lock.
>> 
>> The function addrconf_is_prefix_route() is not used anymore and is
>> removed.
>> 
>> [v2] Minor indentation cleanup and log updates.
>> 
>> Signed-off-by: Romain Kuntz <r.kuntz@ipflavors.com>
>> Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
 ...
> Acked-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
> 

Applied.

      reply	other threads:[~2013-01-10 22:39 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-05 16:13 [PATCH 1/2] ipv6: avoid blackhole and prohibited entries upon prefix purge Romain KUNTZ
2013-01-05 16:19 ` [PATCH 2/2] ipv6: fix packet corruption when Dest/RT2 options are used Romain KUNTZ
2013-01-07 10:49   ` Nicolas Dichtel
2013-01-07 12:41     ` Steffen Klassert
2013-01-11  7:27   ` Romain KUNTZ
2013-01-14  7:21     ` Romain KUNTZ
2013-01-05 19:59 ` [PATCH 1/2] ipv6: avoid blackhole and prohibited entries upon prefix purge Eric Dumazet
2013-01-05 21:44   ` [PATCH 1/2] ipv6: avoid blackhole and prohibited entries upon prefix purge [v2] Romain KUNTZ
2013-01-07 10:25     ` Nicolas Dichtel
2013-01-07 11:30       ` Romain KUNTZ
2013-01-07 15:43         ` Nicolas Dichtel
2013-01-08 11:38           ` Romain KUNTZ
2013-01-08 16:22             ` Nicolas Dichtel
2013-01-08 17:18               ` YOSHIFUJI Hideaki
2013-01-09 14:37                 ` [PATCH 1/2] ipv6: avoid blackhole and prohibited entries upon prefix purge [v3] Romain KUNTZ
2013-01-09 15:11                   ` Nicolas Dichtel
2013-01-10  7:06                     ` Romain KUNTZ
2013-01-10  9:44                       ` [PATCH 1/1] ipv6: use addrconf_get_prefix_route for prefix route lookup [v2] (was [PATCH 1/2] ipv6: avoid blackhole and prohibited entries upon prefix purge [v3]) YOSHIFUJI Hideaki
2013-01-10 22:39                         ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130110.143921.1060148433440698446.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.dichtel@6wind.com \
    --cc=r.kuntz@ipflavors.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).