* [PATCH 1/1] ipv6: fix the noflags test in addrconf_get_prefix_route
@ 2013-01-09 14:36 Romain KUNTZ
2013-01-10 10:00 ` YOSHIFUJI Hideaki
0 siblings, 1 reply; 3+ messages in thread
From: Romain KUNTZ @ 2013-01-09 14:36 UTC (permalink / raw)
To: netdev@vger.kernel.org
Cc: YOSHIFUJI Hideaki, davem@davemloft.net, linux-kernel,
Andreas Hofmeister, Romain KUNTZ
>From e7ece201c35615c44a3cfdc10ee28ad5a5878f41 Mon Sep 17 00:00:00 2001
From: Romain Kuntz <r.kuntz@ipflavors.com>
Date: Wed, 9 Jan 2013 15:02:26 +0100
Subject: [PATCH 1/1] ipv6: fix the noflags test in addrconf_get_prefix_route
The tests on the flags in addrconf_get_prefix_route() does no make
much sense: the 'noflags' parameter contains the set of flags that
must not match with the route flags, so the test must be done
against 'noflags', and not against 'flags'.
Signed-off-by: Romain Kuntz <r.kuntz@ipflavors.com>
---
net/ipv6/addrconf.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index 408cac4a..29ba4ff 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -1877,7 +1877,7 @@ static struct rt6_info *addrconf_get_prefix_route(const struct in6_addr *pfx,
continue;
if ((rt->rt6i_flags & flags) != flags)
continue;
- if ((noflags != 0) && ((rt->rt6i_flags & flags) != 0))
+ if ((rt->rt6i_flags & noflags) != 0)
continue;
dst_hold(&rt->dst);
break;
--
1.7.2.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] ipv6: fix the noflags test in addrconf_get_prefix_route
2013-01-09 14:36 [PATCH 1/1] ipv6: fix the noflags test in addrconf_get_prefix_route Romain KUNTZ
@ 2013-01-10 10:00 ` YOSHIFUJI Hideaki
2013-01-10 22:39 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: YOSHIFUJI Hideaki @ 2013-01-10 10:00 UTC (permalink / raw)
To: Romain KUNTZ, davem@davemloft.net
Cc: netdev@vger.kernel.org, linux-kernel, Andreas Hofmeister,
YOSHIFUJI Hideaki
Romain KUNTZ wrote:
> From e7ece201c35615c44a3cfdc10ee28ad5a5878f41 Mon Sep 17 00:00:00 2001
> From: Romain Kuntz <r.kuntz@ipflavors.com>
> Date: Wed, 9 Jan 2013 15:02:26 +0100
> Subject: [PATCH 1/1] ipv6: fix the noflags test in addrconf_get_prefix_route
>
> The tests on the flags in addrconf_get_prefix_route() does no make
> much sense: the 'noflags' parameter contains the set of flags that
> must not match with the route flags, so the test must be done
> against 'noflags', and not against 'flags'.
>
> Signed-off-by: Romain Kuntz <r.kuntz@ipflavors.com>
> ---
> net/ipv6/addrconf.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
> index 408cac4a..29ba4ff 100644
> --- a/net/ipv6/addrconf.c
> +++ b/net/ipv6/addrconf.c
> @@ -1877,7 +1877,7 @@ static struct rt6_info *addrconf_get_prefix_route(const struct in6_addr *pfx,
> continue;
> if ((rt->rt6i_flags & flags) != flags)
> continue;
> - if ((noflags != 0) && ((rt->rt6i_flags & flags) != 0))
> + if ((rt->rt6i_flags & noflags) != 0)
> continue;
> dst_hold(&rt->dst);
> break;
>
Acked-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
--yoshfuji
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] ipv6: fix the noflags test in addrconf_get_prefix_route
2013-01-10 10:00 ` YOSHIFUJI Hideaki
@ 2013-01-10 22:39 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2013-01-10 22:39 UTC (permalink / raw)
To: yoshfuji; +Cc: r.kuntz, netdev, linux-kernel, andi
From: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Date: Thu, 10 Jan 2013 19:00:33 +0900
> Romain KUNTZ wrote:
>> From e7ece201c35615c44a3cfdc10ee28ad5a5878f41 Mon Sep 17 00:00:00 2001
>> From: Romain Kuntz <r.kuntz@ipflavors.com>
>> Date: Wed, 9 Jan 2013 15:02:26 +0100
>> Subject: [PATCH 1/1] ipv6: fix the noflags test in addrconf_get_prefix_route
>>
>> The tests on the flags in addrconf_get_prefix_route() does no make
>> much sense: the 'noflags' parameter contains the set of flags that
>> must not match with the route flags, so the test must be done
>> against 'noflags', and not against 'flags'.
>>
>> Signed-off-by: Romain Kuntz <r.kuntz@ipflavors.com>
...
> Acked-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-10 22:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-09 14:36 [PATCH 1/1] ipv6: fix the noflags test in addrconf_get_prefix_route Romain KUNTZ
2013-01-10 10:00 ` YOSHIFUJI Hideaki
2013-01-10 22:39 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).