From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: c.becker@traviangames.com, netdev@vger.kernel.org, w@1wt.eu
Subject: Re: tainted warnings with tcp splicing in 3.7.1
Date: Thu, 10 Jan 2013 14:39:55 -0800 (PST) [thread overview]
Message-ID: <20130110.143955.1612875084927284724.davem@davemloft.net> (raw)
In-Reply-To: <1357801149.27446.1142.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 09 Jan 2013 22:59:09 -0800
> [PATCH] tcp: fix splice() and tcp collapsing interaction
>
> Under unusual circumstances, TCP collapse can split a big GRO TCP packet
> while its being used in a splice(socket->pipe) operation.
>
> skb_splice_bits() releases the socket lock before calling
> splice_to_pipe().
>
> [ 1081.353685] WARNING: at net/ipv4/tcp.c:1330 tcp_cleanup_rbuf+0x4d/0xfc()
> [ 1081.371956] Hardware name: System x3690 X5 -[7148Z68]-
> [ 1081.391820] cleanup rbuf bug: copied AD3BCF1 seq AD370AF rcvnxt AD3CF13
>
> To fix this problem, we must eat skbs in tcp_recv_skb().
>
> Remove the inline keyword from tcp_recv_skb() definition since
> it has three call sites.
>
> Reported-by: Christian Becker <c.becker@traviangames.com>
> Cc: Willy Tarreau <w@1wt.eu>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied.
prev parent reply other threads:[~2013-01-10 22:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-09 13:01 tainted warnings with tcp splicing in 3.7.1 Christian Becker
2013-01-09 14:50 ` Lukas Tribus
2013-01-09 17:01 ` Eric Dumazet
2013-01-09 17:09 ` Eric Dumazet
2013-01-10 6:59 ` Eric Dumazet
2013-01-10 7:21 ` Willy Tarreau
2013-01-10 15:29 ` Eric Dumazet
2013-01-10 16:20 ` Eric Dumazet
2013-01-10 18:22 ` Rick Jones
2013-01-10 18:42 ` Eric Dumazet
2013-01-10 18:49 ` Rick Jones
2013-01-10 19:43 ` Willy Tarreau
2013-01-12 0:46 ` [PATCH net-next] net: splice: fix __splice_segment() Eric Dumazet
2013-01-12 0:48 ` David Miller
2013-01-10 18:27 ` tainted warnings with tcp splicing in 3.7.1 Lukas Tribus
2013-01-10 18:37 ` Eric Dumazet
2013-01-10 22:39 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130110.143955.1612875084927284724.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=c.becker@traviangames.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).