From: David Miller <davem@davemloft.net>
To: bh74.an@samsung.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
peppe.cavallaro@st.com, jeffrey.t.kirsher@intel.com,
kgene.kim@samsung.com
Subject: Re: [PATCH v2 3/3] net: stmmac: add gmac autonego set for ethtool support
Date: Thu, 10 Jan 2013 15:57:59 -0800 (PST) [thread overview]
Message-ID: <20130110.155759.127269416182567301.davem@davemloft.net> (raw)
In-Reply-To: <003d01cdef8d$d25b2bf0$771183d0$@samsung.com>
From: Byungho An <bh74.an@samsung.com>
Date: Thu, 10 Jan 2013 15:54:24 -0800
> @@ -348,6 +349,10 @@ stmmac_set_pauseparam(struct net_device *netdev,
>
> if (phy->autoneg) {
> if (netif_running(netdev))
> + if((interface == PHY_INTERFACE_MODE_SGMII) ||
> + (interface == PHY_INTERFACE_MODE_TBI) ||
> + (interface == PHY_INTERFACE_MODE_RTBI))
> + priv->hw->mac->set_autoneg(priv->ioaddr);
This is still not properly formatted.
You also didn't submit this properly. Never use email thread replies
to submit new versions of patches.
Always use fresh, new, mailing list postings to submit new versions
of patches.
Also, when one patch has to change in a series, you must reubmit
the entire set of patches even if some of them have no changes
at all. I do not see patch #2 here at all.
prev parent reply other threads:[~2013-01-10 23:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-08 23:32 [PATCH v2 3/3] net: stmmac: add gmac autonego set for ethtool support Byungho An
2013-01-10 8:02 ` David Miller
2013-01-10 23:54 ` Byungho An
2013-01-10 23:57 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130110.155759.127269416182567301.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bh74.an@samsung.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=kgene.kim@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).