From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] qlge: remove NETIF_F_TSO6 flag Date: Fri, 11 Jan 2013 15:59:19 -0800 (PST) Message-ID: <20130111.155919.809159136231664892.davem@davemloft.net> References: <1357894374-10767-1-git-send-email-amwang@redhat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: amwang@redhat.com, netdev@vger.kernel.org, ron.mercer@qlogic.com, Linux-Driver@qlogic.com To: jitendra.kalsaria@qlogic.com Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:48490 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755380Ab3AKX7U (ORCPT ); Fri, 11 Jan 2013 18:59:20 -0500 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Jitendra Kalsaria Date: Fri, 11 Jan 2013 21:48:52 +0000 > >>From: Cong Wang [mailto:amwang@redhat.com] >>Sent: Friday, January 11, 2013 12:53 AM >>To: netdev >>Cc: Jitendra Kalsaria; Ron Mercer; Dept-Eng Linux Driver; David Miller; Cong Wang >>Subject: [PATCH net] qlge: remove NETIF_F_TSO6 flag >> >>It is werid that qlge driver supports NETIF_F_TSO6 but >>not NETIF_F_IPV6_CSUM. This also causes some kernel warning [1] >>when VLAN device setups on a qlge interface. >> >>I think the qlge hardware doesn't support NETIF_F_IPV6_CSUM, >>so we have to just remove the NETIF_F_TSO6 flag. >> >>After this patch, the TCP/IPv6 traffic becomes normal again, >>no kernel warnings any more. >> >>NOTE: I only tested it on 2.6.32 kernel, even if the upstream >>kernel could fix this automatically (it is hard to track NETIF* >>flags), removing it is also safe. >> >>1. https://bugzilla.redhat.com/show_bug.cgi?id=891839 >> >>Cc: Jitendra Kalsaria >>Cc: Ron Mercer >>Cc: linux-driver@qlogic.com >>Cc: David S. Miller >>Signed-off-by: Cong Wang > > Thanks! > Acked-by: Jitendra Kalsaria Applied.