From: Stefan Hajnoczi <stefanha@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: davem@davemloft.net, mst@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] tuntap: forbid calling TUNSETIFF when detached
Date: Fri, 11 Jan 2013 15:42:36 +0100 [thread overview]
Message-ID: <20130111144236.GC2310@stefanha-thinkpad.muc.redhat.com> (raw)
In-Reply-To: <1357894242-25020-1-git-send-email-jasowang@redhat.com>
On Fri, Jan 11, 2013 at 04:50:41PM +0800, Jason Wang wrote:
> @@ -1546,6 +1544,9 @@ static int tun_set_iff(struct net *net, struct file *file, struct ifreq *ifr)
> struct net_device *dev;
> int err;
>
> + if (rcu_dereference_protected(tfile->detached, lockdep_rtnl_is_held()))
> + return -EINVAL;
> +
How come none of the other tfile->detached users call rcu_*()?
Stefan
next prev parent reply other threads:[~2013-01-11 14:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-11 8:50 [PATCH 1/2] tuntap: forbid calling TUNSETIFF when detached Jason Wang
2013-01-11 8:50 ` [PATCH 2/2] tuntap: fix leaking reference count Jason Wang
2013-01-11 14:42 ` Stefan Hajnoczi [this message]
2013-01-12 2:31 ` [PATCH 1/2] tuntap: forbid calling TUNSETIFF when detached Jason Wang
2013-01-11 14:55 ` Eric Dumazet
2013-01-12 2:31 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130111144236.GC2310@stefanha-thinkpad.muc.redhat.com \
--to=stefanha@redhat.com \
--cc=davem@davemloft.net \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).