From: David Miller <davem@davemloft.net>
To: hauke@hauke-m.de
Cc: mcarlson@broadcom.com, mchan@broadcom.com,
netdev@vger.kernel.org, m@bues.ch
Subject: Re: [PATCH 1/3] ssb: add missing method ssb_gige_get_macaddr
Date: Sat, 12 Jan 2013 15:32:11 -0800 (PST) [thread overview]
Message-ID: <20130112.153211.562541025115995797.davem@davemloft.net> (raw)
In-Reply-To: <1358020905-9924-2-git-send-email-hauke@hauke-m.de>
From: Hauke Mehrtens <hauke@hauke-m.de>
Date: Sat, 12 Jan 2013 21:01:43 +0100
> When CONFIG_SSB_DRIVER_GIGE is not set the header does not provide the
> needed method.
>
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
This isn't right.
You can't implement this function in a way that the caller cannot
determine that it didn't actually do anything.
You either have to protect calls with ifdefs or make this routine
return an error indication, in response to which the caller can
set a random ethernet address or take some other corrective action.
next prev parent reply other threads:[~2013-01-12 23:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-12 20:01 [PATCH 0/3] tg3: add support for Ethernet core in BCM4785 Hauke Mehrtens
2013-01-12 20:01 ` [PATCH 1/3] ssb: add missing method ssb_gige_get_macaddr Hauke Mehrtens
2013-01-12 23:32 ` David Miller [this message]
2013-01-13 9:47 ` Michael Büsch
2013-01-13 22:31 ` Hauke Mehrtens
2013-01-12 20:01 ` [PATCH 2/3] tg3: make it possible to provide phy_id in ioctl Hauke Mehrtens
2013-01-12 20:01 ` [PATCH 3/3] tg3: add support for Ethernet core in bcm4785 Hauke Mehrtens
2013-01-12 23:32 ` [PATCH 0/3] tg3: add support for Ethernet core in BCM4785 David Miller
2013-01-13 22:26 ` Hauke Mehrtens
2013-01-24 17:21 ` Hauke Mehrtens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130112.153211.562541025115995797.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hauke@hauke-m.de \
--cc=m@bues.ch \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).