From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Cc: Stephan Gatzka <stephan.gatzka@gmail.com>,
netdev@vger.kernel.org, linux1394-devel@lists.sourceforge.net
Subject: Re: [RFC PATCH 4/6] firewire net: Export peerinfo handlers.
Date: Sat, 12 Jan 2013 16:01:28 +0100 [thread overview]
Message-ID: <20130112160128.3872495c@stein> (raw)
In-Reply-To: <50F1716A.90401@linux-ipv6.org>
On Jan 12 YOSHIFUJI Hideaki wrote:
[...]
> --- a/drivers/firewire/net.c
> +++ b/drivers/firewire/net.c
[...]
> +EXPORT_SYMBOL(fwnet_update_peerinfo);
[...]
> +EXPORT_SYMBOL(fwnet_fill_peerinfo);
I disagree. drivers/firewire/net.c is no place for EXPORTs.
--
Stefan Richter
-=====-===-= ---= -==--
http://arcgraph.de/sr/
prev parent reply other threads:[~2013-01-12 15:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-12 14:21 [RFC PATCH 4/6] firewire net: Export peerinfo handlers YOSHIFUJI Hideaki
2013-01-12 15:01 ` Stefan Richter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130112160128.3872495c@stein \
--to=stefanr@s5r6.in-berlin.de \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=stephan.gatzka@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).