From: David Miller <davem@davemloft.net>
To: dcbw@redhat.com
Cc: cpuwolf@gmail.com, gregkh@linuxfoundation.org,
alexey.orishko@stericsson.com, bjorn@mork.no,
linux-usb@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] CDC_NCM adding support IFF_NOARP for infineon modem platform
Date: Mon, 14 Jan 2013 13:34:12 -0500 (EST) [thread overview]
Message-ID: <20130114.133412.479351928049237212.davem@davemloft.net> (raw)
In-Reply-To: <1358183953.1713.28.camel@dcbw.foobar.com>
From: Dan Williams <dcbw@redhat.com>
Date: Mon, 14 Jan 2013 11:19:13 -0600
> On Sat, 2013-01-12 at 15:35 -0800, David Miller wrote:
>> From: Wei Shuai <cpuwolf@gmail.com>
>> Date: Sat, 12 Jan 2013 19:34:39 +0800
>>
>> > Infineon(now Intel) HSPA Modem platform NCM cannot support ARP. so I
>> > introduce a flag CDC_NCM_DRIVER_DATA_NOARP which is defined in
>> > driver_info:data. so later on, if more such buggy devices are found,
>> > they could use same flag to handle.
>>
>> Is it no able to do ARP or, the more likely case, does broadcast
>> not work at all?
>>
>> If it's the latter, IFF_NOARP is just making over the real problem.
>>
>> I'm not applying this, no hardware device should set IFF_NOARP.
>> You probably really want IFF_POINTOPOINT or similar.
>
> IFF_NOARP is already done for other WWAN devices (sierra_net, hso,
> cdc-ether, cdc-phonet, lg-vl600, etc) so there is some precedent. Some
> drivers (phonet, hso) set *both* POINTTOPOINT and NOARP. Is that
> redundant, and should all WWAN drivers be moved to only POINTTOPOINT?
>
> (aside: usbnet has FLAG_POINTTOPOINT, but that's nothing to do with
> IFF_POINTTOPOINT, it only controls whether the interface is named usbX
> or ethX. Confusing.)
I can't answer any of your questions unless you tell me what the
real limitation of these devices is.
For the second time, is the problem that these devices cannot
support broadcast packets properly?
next prev parent reply other threads:[~2013-01-14 18:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-12 11:34 [PATCH] CDC_NCM adding support IFF_NOARP for infineon modem platform Wei Shuai
2013-01-12 23:35 ` David Miller
2013-01-14 17:19 ` Dan Williams
2013-01-14 18:34 ` David Miller [this message]
2013-01-15 0:41 ` Peter Stuge
2013-01-15 8:34 ` Bjørn Mork
[not found] ` <87hamikfpc.fsf-lbf33ChDnrE/G1V5fR+Y7Q@public.gmane.org>
2013-01-16 21:18 ` David Miller
2013-01-15 13:11 ` Wei Shuai
[not found] ` <1357990479-5836-1-git-send-email-cpuwolf-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-01-16 21:45 ` Dan Williams
2013-01-17 6:44 ` Wei Shuai
2013-01-18 17:43 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130114.133412.479351928049237212.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexey.orishko@stericsson.com \
--cc=bjorn@mork.no \
--cc=cpuwolf@gmail.com \
--cc=dcbw@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).