From: David Miller <davem@davemloft.net>
To: hkchu@google.com
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org,
ketkulka@gmail.com, ycheng@google.com
Subject: Re: [PATCH] tcp: fix a panic on UP machines in reqsk_fastopen_remove
Date: Mon, 14 Jan 2013 18:10:30 -0500 (EST) [thread overview]
Message-ID: <20130114.181030.1911364060960863615.davem@davemloft.net> (raw)
In-Reply-To: <CAPshTCiNcSPbC7uCzo5MV2tGuZyoCwyE_XKcGb9smknZ8Rqb2w@mail.gmail.com>
From: Jerry Chu <hkchu@google.com>
Date: Mon, 14 Jan 2013 00:26:26 -0800
> On Sun, Jan 13, 2013 at 8:21 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>> From: Eric Dumazet <edumazet@google.com>
>>
>> spin_is_locked() on a non !SMP build is kind of useless.
>>
>> BUG_ON(!spin_is_locked(xx)) is guaranteed to crash.
>>
>> Just remove this check in reqsk_fastopen_remove() as
>> the callers do hold the socket lock.
>>
>> Reported-by: Ketan Kulkarni <ketkulka@gmail.com>
>> Signed-off-by: Eric Dumazet <edumazet@google.com>
...
> Thanks, Eric. (I thought the assertion would be transparent to UP...)
>
> Acked-by: H.K. Jerry Chu <hkchu@google.com>
>
Applied, thanks.
prev parent reply other threads:[~2013-01-14 23:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-14 4:21 [PATCH] tcp: fix a panic on UP machines in reqsk_fastopen_remove Eric Dumazet
2013-01-14 8:26 ` Jerry Chu
2013-01-14 23:10 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130114.181030.1911364060960863615.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=hkchu@google.com \
--cc=ketkulka@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).