From: David Miller <davem@davemloft.net>
To: harvey.huawei.yang@gmail.com
Cc: kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] net: ipv4: refine the logic for determining daddr in ip_queue_xmit.
Date: Mon, 14 Jan 2013 23:48:07 -0500 (EST) [thread overview]
Message-ID: <20130114.234807.263597221162955409.davem@davemloft.net> (raw)
In-Reply-To: <1358225255-30973-1-git-send-email-harvey.huawei.yang@gmail.com>
From: Harvey Yang <harvey.huawei.yang@gmail.com>
Date: Tue, 15 Jan 2013 12:47:35 +0800
> The destination address daddr is faddr if source route option is set, otherwise it is inet_daddr. So use if-else to assign the value.
>
> Signed-off-by: Harvey Yang <harvey.huawei.yang@gmail.com>
You are changing nothing in how this code behaves. And stylistically
I know it was coded this way on purpose, because I'm pretty sure I
wrote it.
next prev parent reply other threads:[~2013-01-15 4:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-15 4:47 [PATCH 1/1] net: ipv4: refine the logic for determining daddr in ip_queue_xmit Harvey Yang
2013-01-15 4:48 ` David Miller [this message]
2013-01-15 4:57 ` Eric Dumazet
2013-01-15 10:12 ` Cong Ding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130114.234807.263597221162955409.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=harvey.huawei.yang@gmail.com \
--cc=jmorris@namei.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).