Netdev List
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Tom Herbert <therbert@google.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
	netdev@markandruth.co.uk, eric.dumazet@gmail.com
Subject: Re: [PATCH 1/5] soreuseport: infrastructure
Date: Tue, 15 Jan 2013 07:53:23 -0800	[thread overview]
Message-ID: <20130115075323.64b2fdc7@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <alpine.DEB.2.00.1301141152130.3433@pokey.mtv.corp.google.com>

On Mon, 14 Jan 2013 12:00:18 -0800 (PST)
Tom Herbert <therbert@google.com> wrote:

> +/* Pseudo random number generator from numerical recipes. */
> +static inline u32 next_pseudo_random32(u32 seed)
> +{
> +	return seed * 1664525 + 1013904223;
> +}
> +

Don't reimplement a pseudo random number generator, there already
exists net_random() 

  reply	other threads:[~2013-01-15 15:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-14 20:00 [PATCH 1/5] soreuseport: infrastructure Tom Herbert
2013-01-15 15:53 ` Stephen Hemminger [this message]
2013-01-15 16:14   ` Eric Dumazet
2013-01-16 18:37     ` Tom Herbert
2013-01-16 19:13       ` Eric Dumazet
     [not found]         ` <20130116224734.GA28741@ppwaskie-mobl2.jf.intel.com>
2013-01-20 23:33           ` Tom Herbert
  -- strict thread matches above, loose matches on Subject: below --
2013-01-22 19:49 Tom Herbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130115075323.64b2fdc7@nehalam.linuxnetplumber.net \
    --to=stephen@networkplumber.org \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@markandruth.co.uk \
    --cc=netdev@vger.kernel.org \
    --cc=therbert@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox