From: Antonio Quartulli <ordex-GaUfNO9RBHfsrOwW+9ziJQ@public.gmane.org>
To: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org,
Marek Lindner <lindner_marek-LWAfsSFWpa4@public.gmane.org>,
davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org
Subject: Re: [PATCH 15/15] batman-adv: unbloat batadv_priv if debug is not enabled
Date: Tue, 15 Jan 2013 18:53:13 +1000 [thread overview]
Message-ID: <20130115085313.GC30484@ritirata.org> (raw)
In-Reply-To: <1358185000.19400.15.camel@joe-AO722>
[-- Attachment #1: Type: text/plain, Size: 1220 bytes --]
Hi Joe,
On Mon, Jan 14, 2013 at 09:36:40 -0800, Joe Perches wrote:
> On Mon, 2013-01-14 at 09:41 +1000, Antonio Quartulli wrote:
> > diff --git a/net/batman-adv/types.h b/net/batman-adv/types.h
> []
> > @@ -284,12 +284,16 @@ struct batadv_priv {
> > atomic_t gw_bandwidth; /* gw bandwidth */
> > atomic_t orig_interval; /* uint */
> > atomic_t hop_penalty; /* uint */
> > +#ifdef CONFIG_BATMAN_ADV_DEBUG
> > atomic_t log_level; /* uint */
> > +#endif
> > atomic_t bcast_seqno;
> > atomic_t bcast_queue_left;
> > atomic_t batman_queue_left;
> > char num_ifaces;
> > +#ifdef CONFIG_BATMAN_ADV_DEBUG
> > struct batadv_debug_log *debug_log;
> > +#endif
> > struct kobject *mesh_obj;
> > struct dentry *debug_dir;
> > struct hlist_head forw_bat_list;
>
> How about moving one of these so
> there's only one #ifdef block.
Yeah. This is the main struct and actually it still needs some more housekeeping
(and some love).
It was initially sorted in another way, but as soon as we added new features it
lost its shape.
We will take care of that.
Thanks a lot!
Cheers,
--
Antonio Quartulli
..each of us alone is worth nothing..
Ernesto "Che" Guevara
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-01-15 8:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-13 23:41 pull request: batman-adv 2013-01-14 Antonio Quartulli
2013-01-13 23:41 ` [PATCH 01/15] batman-adv: use per_cpu_add helper Antonio Quartulli
2013-01-13 23:41 ` [PATCH 02/15] batman-adv: Do not add multicast MAC addresses to translation table Antonio Quartulli
2013-01-13 23:41 ` [PATCH 03/15] batman-adv: reduce local TT entry timeout to 10 minutes Antonio Quartulli
2013-01-13 23:41 ` [PATCH 04/15] batman-adv: improve local translation table output Antonio Quartulli
2013-01-13 23:41 ` [PATCH 05/15] batman-adv: print the CRC together with the translation tables Antonio Quartulli
2013-01-13 23:41 ` [PATCH 06/15] batman-adv: unify and properly print hex values Antonio Quartulli
2013-01-13 23:41 ` [PATCH 07/15] batman-adv: remove useless assignment in tt_local_add() Antonio Quartulli
2013-01-13 23:41 ` [PATCH 08/15] batman-adv: Initialize lockdep class keys for hashes Antonio Quartulli
2013-01-13 23:41 ` [PATCH 09/15] batman-adv: remove useless blank lines before and after brackets Antonio Quartulli
2013-01-13 23:41 ` [PATCH 10/15] batman-adv: remove useless NULL check Antonio Quartulli
2013-01-13 23:41 ` [PATCH 11/15] batman-adv: don't compile the BLA switch if not requested Antonio Quartulli
2013-01-13 23:41 ` [PATCH 12/15] batman-adv: use the const qualifier in hash functions Antonio Quartulli
2013-01-13 23:41 ` [PATCH 13/15] batman-adv: fix typo in debug message Antonio Quartulli
2013-01-13 23:41 ` [PATCH 14/15] batman-adv: remove unused variable from orig_node struct Antonio Quartulli
2013-01-13 23:41 ` [PATCH 15/15] batman-adv: unbloat batadv_priv if debug is not enabled Antonio Quartulli
2013-01-14 17:36 ` Joe Perches
2013-01-15 8:53 ` Antonio Quartulli [this message]
2013-01-14 1:39 ` pull request: batman-adv 2013-01-14 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130115085313.GC30484@ritirata.org \
--to=ordex-gaufno9rbhfsroww+9zijq@public.gmane.org \
--cc=b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org \
--cc=lindner_marek-LWAfsSFWpa4@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).