From: David Miller <davem@davemloft.net>
To: timo.teras@iki.fi
Cc: romieu@fr.zoreil.com, netdev@vger.kernel.org
Subject: Re: [PATCH] r8169: remove unneeded dirty_rx index
Date: Wed, 16 Jan 2013 16:25:00 -0500 (EST) [thread overview]
Message-ID: <20130116.162500.1216966272191204366.davem@davemloft.net> (raw)
In-Reply-To: <1358319684-32364-1-git-send-email-timo.teras@iki.fi>
From: Timo Teräs <timo.teras@iki.fi>
Date: Wed, 16 Jan 2013 09:01:24 +0200
> @@ -6035,10 +6034,8 @@ static int rtl_rx(struct net_device *dev, struct rtl8169_private *tp, u32 budget
> unsigned int count;
>
> cur_rx = tp->cur_rx;
> - rx_left = NUM_RX_DESC + tp->dirty_rx - cur_rx;
> - rx_left = min(rx_left, budget);
>
> - for (; rx_left > 0; rx_left--, cur_rx++) {
> + for (rx_left = min(budget, NUM_RX_DESC); rx_left > 0; rx_left--, cur_rx++) {
Is this really equivalent? I think cur_rx still needs to be
incorporated into whatever you use as the initial rx_left.
next prev parent reply other threads:[~2013-01-16 21:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-08 8:28 r8169 rx_missed increasing in bursts (regression) Timo Teras
2013-01-08 22:58 ` Francois Romieu
2013-01-09 9:58 ` Timo Teras
2013-01-09 17:14 ` Timo Teras
2013-01-15 8:11 ` Timo Teras
2013-01-15 22:53 ` Francois Romieu
2013-01-16 7:01 ` [PATCH] r8169: remove unneeded dirty_rx index Timo Teräs
2013-01-16 21:25 ` David Miller [this message]
2013-01-16 21:26 ` Francois Romieu
2013-01-16 22:16 ` Francois Romieu
2013-01-16 23:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130116.162500.1216966272191204366.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
--cc=timo.teras@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).