From: David Miller <davem@davemloft.net>
To: vyasevich@gmail.com
Cc: nhorman@tuxdriver.com, linux-sctp@vger.kernel.org,
Jamie.Parsons@metaswitch.com, netdev@vger.kernel.org
Subject: Re: [PATCH] sctp: refactor sctp_outq_teardown to insure proper re-initalization
Date: Thu, 17 Jan 2013 18:40:38 -0500 (EST) [thread overview]
Message-ID: <20130117.184038.2028006072256759665.davem@davemloft.net> (raw)
In-Reply-To: <50F87FB4.3070604@gmail.com>
From: Vlad Yasevich <vyasevich@gmail.com>
Date: Thu, 17 Jan 2013 17:48:20 -0500
> On 01/17/2013 04:15 PM, Neil Horman wrote:
>> Jamie Parsons reported a problem recently, in which the
>> re-initalization of an
>> association (The duplicate init case), resulted in a loss of receive
>> window
>> space. He tracked down the root cause to sctp_outq_teardown, which
>> discarded
>> all the data on an outq during a re-initalization of the corresponding
>> association, but never reset the outq->outstanding_data field to zero.
>> I wrote,
>> and he tested this fix, which does a proper full re-initalization of
>> the outq,
>> fixing this problem, and hopefully future proofing us from simmilar
>> issues down
>> the road.
>>
>
> Good find.
>
> Acked-by: Vlad Yasevich <vyasevich@gmail.com>
Applied and queued up for -stable, thanks everyone.
prev parent reply other threads:[~2013-01-17 23:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-17 21:15 [PATCH] sctp: refactor sctp_outq_teardown to insure proper re-initalization Neil Horman
2013-01-17 22:48 ` Vlad Yasevich
2013-01-17 23:40 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130117.184038.2028006072256759665.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Jamie.Parsons@metaswitch.com \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).