From: Steffen Klassert <steffen.klassert@secunet.com>
To: Julian Anastasov <ja@ssi.bg>
Cc: David Miller <davem@davemloft.net>,
timo.teras@iki.fi, luky-37@hotmail.com, pupilla@libero.it,
netdev@vger.kernel.org
Subject: Re: [PATCH] ipv4: Remove output route check in ipv4_mtu
Date: Thu, 17 Jan 2013 07:31:00 +0100 [thread overview]
Message-ID: <20130117063100.GF18940@secunet.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1301162236320.1760@ja.ssi.bg>
On Wed, Jan 16, 2013 at 11:01:39PM +0200, Julian Anastasov wrote:
>
> On Wed, 16 Jan 2013, Steffen Klassert wrote:
> >
> > Not absolutely sure what you want to do if the mtu is locked.
> > But if you don't want to genetate a nh exception and don't update
> > rt->rt_pmtu in this case, rt->rt_pmtu is never set on routes with
> > locked mtu. We probably would not need to change ipv4_mtu() to the
> > above variant.
>
> Yes, we have to exit __ip_rt_update_pmtu if
> fib_mtu is locked. Then rt_pmtu should stay 0 and
> your variant of ipv4_mtu should be ok. I hope you
> can simply extend your patch with such additional
> check in __ip_rt_update_pmtu:
>
> if (dst_metric_locked(dst, RTAX_MTU))
> return;
>
That's what I had in mind. I'll do that with an additional
patch, it's a another issue.
Thanks for the input!
prev parent reply other threads:[~2013-01-17 6:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 6:36 [PATCH] ipv4: Remove output route check in ipv4_mtu Steffen Klassert
2013-01-16 8:58 ` Julian Anastasov
2013-01-16 9:59 ` Steffen Klassert
2013-01-16 21:01 ` Julian Anastasov
2013-01-17 6:31 ` Steffen Klassert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130117063100.GF18940@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=davem@davemloft.net \
--cc=ja@ssi.bg \
--cc=luky-37@hotmail.com \
--cc=netdev@vger.kernel.org \
--cc=pupilla@libero.it \
--cc=timo.teras@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).