From: Thomas Graf <tgraf@suug.ch>
To: David Laight <David.Laight@ACULAB.COM>
Cc: Cong Wang <amwang@redhat.com>,
netdev@vger.kernel.org, Eric Dumazet <eric.dumazet@gmail.com>,
Rick Jones <rick.jones2@hp.com>,
Stephen Hemminger <shemminger@vyatta.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [RFC Patch net-next] tcp: add a global sysctl to control TCP delayed ack
Date: Thu, 17 Jan 2013 12:34:20 +0000 [thread overview]
Message-ID: <20130117123420.GA23639@casper.infradead.org> (raw)
In-Reply-To: <AE90C24D6B3A694183C094C60CF0A2F6026B7110@saturn3.aculab.com>
On 01/16/13 at 12:22pm, David Laight wrote:
> A sysctl is a bit of a big hammer, it probably isn't necessary
> to disable delayed acks on all connections.
>
> IIRC the related problems I saw were really on the sending
> side when Nagle is disabled and it is doing 'slow start'.
>
> Globally disabling on connections that have Nagle disabled
> might be a possibility - but it is the Nagle parameter
> at the other end that matters.
>
> Perhaps the sending side, after sending 4 small frames immediately,
> could send 1 or 2 additional full sized frames in order to
> provoke an ack (IIRC an ack is sent if there are 2 full sized
> frames of data unacked).
>
> The other problem is that 'slow start' is restarted very
> aggressively - whenever there is no unacked data.
> If you have a very low latency connection and aren't doing
> continuous bulk transfer it is restarted for every short
> burst of transmits - effectively after every received ack.
> There really ought to have to be a moderate idle time
> before 'slow start' is restarted.
Not that I disagree with this fundamentally but we already
have a socket option to enable the functionality. All this
patch does is making the same functionality available to
users that are not able to make modification on the
application level.
We can argue about making it available as route metric
exclusively though.
next prev parent reply other threads:[~2013-01-17 12:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 11:05 [RFC Patch net-next] tcp: add a global sysctl to control TCP delayed ack Cong Wang
2013-01-16 12:22 ` David Laight
2013-01-17 9:21 ` Cong Wang
2013-01-17 12:34 ` Thomas Graf [this message]
2013-01-17 13:25 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130117123420.GA23639@casper.infradead.org \
--to=tgraf@suug.ch \
--cc=David.Laight@ACULAB.COM \
--cc=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rick.jones2@hp.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).