* [PATCH] net: fix wrong length of mac address
@ 2013-01-18 2:15 Amos Kong
2013-01-18 7:14 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Amos Kong @ 2013-01-18 2:15 UTC (permalink / raw)
To: netdev, davem; +Cc: devel, Amos Kong
Replace hardcode 14 with defined ETN_ALEN.
Signed-off-by: Amos Kong <kongjianjun@gmail.com>
---
drivers/net/hyperv/netvsc_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
index f825a62..8264f0e 100644
--- a/drivers/net/hyperv/netvsc_drv.c
+++ b/drivers/net/hyperv/netvsc_drv.c
@@ -349,7 +349,7 @@ static int netvsc_set_mac_addr(struct net_device *ndev, void *p)
struct net_device_context *ndevctx = netdev_priv(ndev);
struct hv_device *hdev = ndevctx->device_ctx;
struct sockaddr *addr = p;
- char save_adr[14];
+ char save_adr[ETH_ALEN];
unsigned char save_aatype;
int err;
--
1.7.11.7
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: fix wrong length of mac address
2013-01-18 2:15 [PATCH] net: fix wrong length of mac address Amos Kong
@ 2013-01-18 7:14 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2013-01-18 7:14 UTC (permalink / raw)
To: Amos Kong; +Cc: netdev, davem, devel
You should still CC Haiyang Zhang and KY (as well as netdev). Use
./scripts/get_maintainer.pl -f drivers/net/hyperv/netvsc_drv.c
to find out where to send patches.
On Fri, Jan 18, 2013 at 10:15:21AM +0800, Amos Kong wrote:
> Replace hardcode 14 with defined ETN_ALEN.
^
Typo. It should be ETH_ALEN.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-18 7:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-18 2:15 [PATCH] net: fix wrong length of mac address Amos Kong
2013-01-18 7:14 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).