netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: patrik.karlin@gmail.com
Cc: chas@cmf.nrl.navy.mil, linux-atm-general@lists.sourceforge.net,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] drivers: atm: checkpatch.pl fixed coding style issues in eni.c
Date: Sun, 20 Jan 2013 23:04:28 -0500 (EST)	[thread overview]
Message-ID: <20130120.230428.1678269076372823495.davem@davemloft.net> (raw)
In-Reply-To: <1358723575-8345-5-git-send-email-patrik.karlin@gmail.com>

From: Patrik Karlin <patrik.karlin@gmail.com>
Date: Mon, 21 Jan 2013 00:12:55 +0100

> This patch fixes statement placement around if/else/for statments
> as suggested by checkpatch.pl
> 
> Signed-off-by: Patrik Kårlin <patrik.karlin@gmail.com>

This patch set is a good example of why nobody should
fix up coding style in such a robotic way in response
to codingstyle.pl complaints.

> -		    ATM_MAX_AAL5_PDU) eff = (length+3) >> 2;
> +		    ATM_MAX_AAL5_PDU) 

I bet you didn't even notice that in this change you are adding
trailing whitespace, the exact problem you fixed up for this file in a
previous patch of the series.

I really would encourage you to work on something else entirely.

Thanks.

      reply	other threads:[~2013-01-21  4:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-20 23:12 [PATCH 1/5] drivers: atm: checkpatch.pl fixed coding style errors in eni.c Patrik Karlin
2013-01-20 23:12 ` [PATCH 2/5] drivers: atm: checkpatch.pl fixes removed all trailing whitespaces " Patrik Karlin
2013-01-20 23:12 ` [PATCH 3/5] drivers: atm: checkpatch.pl fixed tabbed indentation " Patrik Karlin
2013-01-20 23:12 ` [PATCH 4/5] drivers: atm: checkpatch.pl changed headers from asm/* to linux/* " Patrik Karlin
2013-01-20 23:12 ` [PATCH 5/5] drivers: atm: checkpatch.pl fixed coding style issues " Patrik Karlin
2013-01-21  4:04   ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130120.230428.1678269076372823495.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=chas@cmf.nrl.navy.mil \
    --cc=linux-atm-general@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=patrik.karlin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).