From: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
To: cpuwolf-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Cc: sshtylyov-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org,
dcbw-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
peter-Y+HMSxxDrH8@public.gmane.org,
oneukum-l3A5Bk7waGM@public.gmane.org,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
alexey.orishko-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org,
bjorn-yOkvZcmFvRU@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/2] CDC_NCM: adding support FLAG_NOARP for Infineon modem platform
Date: Sun, 20 Jan 2013 23:09:02 -0500 (EST) [thread overview]
Message-ID: <20130120.230902.1326170122198671921.davem@davemloft.net> (raw)
In-Reply-To: <CACa7zynymtYN4OtTjVNTNdB23eNU4D-G+JqaTxjaPFekRHkRAg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
From: Wei Shuai <cpuwolf-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date: Mon, 21 Jan 2013 10:20:22 +0800
> The main problem is that these devices don't support ethernet.
He's saying your comment is referring to the wrong thing,
rather than saying anything against what your change is
doing.
Read his feedback carefully:
>>> +/* Same as wwan_info, but with IFF_NOARP */
>>
>> FLAG_NOARP, you mean?
He's saying your commnet is talking about FLAG_NOARP rather
than what the core code does with this flag, which is
translate into setting IFF_NOARP on the net device.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-01-21 4:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-20 6:12 [PATCH 1/2] usbnet: add flag FLAG_NOARP for usb net devices Wei Shuai
2013-01-20 6:12 ` [PATCH 2/2] CDC_NCM: adding support FLAG_NOARP for Infineon modem platform Wei Shuai
[not found] ` <1358662329-8294-2-git-send-email-cpuwolf-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-01-20 17:13 ` Sergei Shtylyov
2013-01-21 2:20 ` Wei Shuai
[not found] ` <CACa7zynymtYN4OtTjVNTNdB23eNU4D-G+JqaTxjaPFekRHkRAg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-01-21 4:09 ` David Miller [this message]
2013-01-21 8:22 ` Wei Shuai
2013-01-21 11:33 ` Sergei Shtylyov
-- strict thread matches above, loose matches on Subject: below --
2013-01-19 11:53 [PATCH 1/2] introduce flag FLAG_NOARP for usb net devices which cannot do ARP Wei Shuai
[not found] ` <1358596401-7209-1-git-send-email-cpuwolf-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-01-19 11:53 ` [PATCH 2/2] CDC_NCM adding support FLAG_NOARP for Infineon modem platform Wei Shuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130120.230902.1326170122198671921.davem@davemloft.net \
--to=davem-ft/pcqaiutieiz0/mpfg9q@public.gmane.org \
--cc=alexey.orishko-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org \
--cc=bjorn-yOkvZcmFvRU@public.gmane.org \
--cc=cpuwolf-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=dcbw-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=oneukum-l3A5Bk7waGM@public.gmane.org \
--cc=peter-Y+HMSxxDrH8@public.gmane.org \
--cc=sshtylyov-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).