From: Steffen Klassert <steffen.klassert@secunet.com>
To: Julian Anastasov <ja@ssi.bg>
Cc: "Yurij M. Plotnikov" <Yurij.Plotnikov@oktetlabs.ru>,
Ben Hutchings <bhutchings@solarflare.com>,
netdev@vger.kernel.org,
"Alexandra N. Kossovsky" <Alexandra.Kossovsky@oktetlabs.ru>
Subject: Re: [RFC PATCH 1/3] ipv4: Invalidate the socket cached route on pmtu events if possible
Date: Mon, 21 Jan 2013 07:43:26 +0100 [thread overview]
Message-ID: <20130121064326.GA30530@secunet.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1301190031080.1803@ja.ssi.bg>
On Sat, Jan 19, 2013 at 02:54:04AM +0200, Julian Anastasov wrote:
> > +
> > +void ipv4_sk_update_pmtu(struct sk_buff *skb, struct sock *sk, u32 mtu)
> > +{
> > + const struct iphdr *iph = (const struct iphdr *) skb->data;
> > + struct flowi4 fl4;
> > + struct rtable *rt = (struct rtable *) __sk_dst_get(sk);
>
> I guess __sk_dst_get should be called after
> bh_lock_sock ?
Yes, absolutely. I'll fix it before I submit the patch.
Thanks for your review!
next prev parent reply other threads:[~2013-01-21 6:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-19 13:10 PMTU discovery is broken on kernel 3.7.1 for UDP sockets Yurij M. Plotnikov
2012-12-19 13:35 ` Ben Hutchings
2012-12-19 14:27 ` Yurij M. Plotnikov
2012-12-19 19:37 ` Ben Hutchings
2012-12-20 7:14 ` Yurij M. Plotnikov
2012-12-20 7:34 ` Steffen Klassert
2012-12-20 11:22 ` Yurij M. Plotnikov
2012-12-20 12:35 ` Steffen Klassert
2012-12-21 10:22 ` Steffen Klassert
2013-01-14 8:26 ` Yurij M. Plotnikov
2013-01-14 12:52 ` Steffen Klassert
2013-01-18 8:11 ` Steffen Klassert
2013-01-18 8:14 ` [RFC PATCH 1/3] ipv4: Invalidate the socket cached route on pmtu events if possible Steffen Klassert
2013-01-18 19:38 ` David Miller
2013-01-19 0:54 ` Julian Anastasov
2013-01-21 6:43 ` Steffen Klassert [this message]
2013-01-18 8:15 ` [RFC PATCH 2/3] ipv4: Add a socket release callback for datagram sockets Steffen Klassert
2013-01-18 19:39 ` David Miller
2013-01-18 8:16 ` [RFC PATCH 3/3] xfrm4: Invalidate all ipv4 routes on IPsec pmtu events Steffen Klassert
2013-01-18 19:39 ` David Miller
2013-01-21 6:48 ` Steffen Klassert
2013-01-21 12:04 ` Steffen Klassert
2013-01-21 11:31 ` PMTU discovery is broken on kernel 3.7.1 for UDP sockets Yurij M. Plotnikov
2013-01-21 11:38 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130121064326.GA30530@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=Alexandra.Kossovsky@oktetlabs.ru \
--cc=Yurij.Plotnikov@oktetlabs.ru \
--cc=bhutchings@solarflare.com \
--cc=ja@ssi.bg \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).