From: David Miller <davem@davemloft.net>
To: steffen.klassert@secunet.com
Cc: ja@ssi.bg, netdev@vger.kernel.org
Subject: Re: [PATCH] ipv4: Fix route refcount on pmtu discovery
Date: Tue, 22 Jan 2013 14:23:52 -0500 (EST) [thread overview]
Message-ID: <20130122.142352.297304738389100208.davem@davemloft.net> (raw)
In-Reply-To: <20130122100128.GD9147@secunet.com>
From: Steffen Klassert <steffen.klassert@secunet.com>
Date: Tue, 22 Jan 2013 11:01:28 +0100
> git commit 9cb3a50c (ipv4: Invalidate the socket cached route on
> pmtu events if possible) introduced a refcount problem. We don't
> get a refcount on the route if we get it from__sk_dst_get(), but
> we need one if we want to reuse this route because __sk_dst_set()
> releases the refcount of the old route. This patch adds proper
> refcount handling for that case. We introduce a 'new' flag to
> indicate that we are going to use a new route and we release the
> old route only if we replace it by a new one.
>
> Reported-by: Julian Anastasov <ja@ssi.bg>
> Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
Applied, thanks.
prev parent reply other threads:[~2013-01-22 19:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-22 10:01 [PATCH] ipv4: Fix route refcount on pmtu discovery Steffen Klassert
2013-01-22 19:23 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130122.142352.297304738389100208.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ja@ssi.bg \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).