From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: pshelar@nicira.com, netdev@vger.kernel.org, jesse@nicira.com
Subject: Re: [PATCH 2/2] IP_GRE: Linearize skb before csum.
Date: Tue, 22 Jan 2013 17:08:26 -0500 (EST) [thread overview]
Message-ID: <20130122.170826.1481012610894653735.davem@davemloft.net> (raw)
In-Reply-To: <1358892199.12374.139.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 22 Jan 2013 14:03:19 -0800
> An application changing data provided on a sendfile() or vmsplice() cant
> really expect data integrity being respected, even if checksum are done
> by the NIC (TSO)
>
> So if data integrity is not respected, just send a bogus TX checksum.
I disagree.
As a quality of implementation decision, we should always compute
correct checksums, ragardless of whether the page contents can be
modified asynchronously during the packet transmit.
next prev parent reply other threads:[~2013-01-22 22:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-22 21:20 [PATCH 2/2] IP_GRE: Linearize skb before csum Pravin B Shelar
2013-01-22 22:03 ` Eric Dumazet
2013-01-22 22:08 ` David Miller [this message]
2013-01-22 22:15 ` Eric Dumazet
2013-01-22 22:30 ` Pravin Shelar
2013-01-22 22:38 ` Jesse Gross
2013-01-22 22:44 ` Eric Dumazet
2013-01-23 0:41 ` David Miller
2013-01-23 1:08 ` Eric Dumazet
2013-01-23 1:46 ` David Miller
2013-01-23 4:22 ` David Miller
2013-01-23 5:02 ` Eric Dumazet
2013-01-23 5:19 ` David Miller
2013-01-23 5:30 ` Eric Dumazet
2013-01-23 5:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130122.170826.1481012610894653735.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jesse@nicira.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).