From: David Miller <davem@davemloft.net>
To: David.Choi@Micrel.Com
Cc: netdev@vger.kernel.org, Ping.Doong@Micrel.Com
Subject: Re: [PATCH net-next] drivers/net/ethernet/micrel/ks8851_mll: Implement basic statistics
Date: Tue, 22 Jan 2013 20:51:32 -0500 (EST) [thread overview]
Message-ID: <20130122.205132.2281610193783011537.davem@davemloft.net> (raw)
In-Reply-To: <FD9AD8C5375B924CABC56D982DB3A802079D32D1@EXMB1.micrel.com>
From: "Choi, David" <David.Choi@Micrel.Com>
Date: Wed, 23 Jan 2013 01:40:41 +0000
> From: David J. Choi <david.choi@micrel.com>
>
> Summary of changes:
> add codes to collect basic statistical information about Ethernet packets.
>
> Signed-off-by: David J. Choi <david.choi@micrel.com>
A Subject prefix of "ks8851_mll: " is sufficient, people who want the
whole patch name can simply look at the patch.
> + if (frame_hdr->sts & RXFSHR_RXFV)
This line has trailing whitespace errors.
> + netdev->stats.rx_frame_errors++;
> pr_err("%s: err:skb alloc\n", __func__);
BTW it's inappropriate to log an SKB allocation failure as an error in
the kernel logs like this. This can be completely normal on a heavily
loaded system. People can look at the device statistics to learn about
this event, or use a more sophisticated tool like the drop monitor.
next prev parent reply other threads:[~2013-01-23 1:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-23 1:40 [PATCH net-next] drivers/net/ethernet/micrel/ks8851_mll: Implement basic statistics Choi, David
2013-01-23 1:51 ` David Miller [this message]
2013-01-23 3:57 ` Joe Perches
2013-01-23 4:17 ` David Miller
2013-01-23 4:27 ` Joe Perches
-- strict thread matches above, loose matches on Subject: below --
2013-01-23 18:46 Choi, David
2013-01-23 19:09 ` Joe Perches
2013-01-23 19:36 ` Choi, David
2013-01-29 1:34 ` Joe Perches
2013-01-28 23:39 ` David Miller
2013-01-29 1:21 ` Choi, David
2013-01-29 18:24 Choi, David
2013-01-29 18:42 ` Joe Perches
2013-01-29 18:55 ` David Miller
2013-01-29 19:09 ` Joe Perches
2013-01-29 19:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130122.205132.2281610193783011537.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=David.Choi@Micrel.Com \
--cc=Ping.Doong@Micrel.Com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).