From: David Miller <davem@davemloft.net>
To: sanagi.koki@jp.fujitsu.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] skb: add a comment to skb_csum_unnecessary to avoid miuse
Date: Tue, 22 Jan 2013 23:13:53 -0500 (EST) [thread overview]
Message-ID: <20130122.231353.2100388787067184936.davem@davemloft.net> (raw)
In-Reply-To: <F6CB40852BC6EF489E0AA83EFF537F470876B9FD@G01JPEXMBYT04>
From: "Sanagi, Koki" <sanagi.koki@jp.fujitsu.com>
Date: Wed, 23 Jan 2013 02:32:52 +0000
>> From: Koki Sanagi <sanagi.koki@jp.fujitsu.com>
>> Date: Wed, 23 Jan 2013 09:30:16 +0900
>>
>> > Due to its name and appearance, someone thinks this only checks if
>> > ip_summed is CHECKSUM_UNNECESARRY. But actually, this returns true
>> > even if ip_summed is CHECKSUM_PARTIAL. To avoid misuse, this patch a
>> > comment which specifies that CHECKSUM_PARTIAL is OK.
>> >
>> > Signed-off-by: Koki Sanagi <sanagi.koki@jp.fujitsu.com>
>>
>> I'm not applying this, sorry. It's a one line function and it's not so
>> non-obvious that it deserves an 8 line comment.
>
> OK. I just felt weird that CHECKSUM_* is not bit flag but this function handles
> it as if it was bit flag.
The function name says what it does, it determines whether a checksum
is necessary or not. How that is implemented is another issue.
next prev parent reply other threads:[~2013-01-23 4:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-23 0:30 [PATCH] skb: add a comment to skb_csum_unnecessary to avoid miuse Koki Sanagi
2013-01-23 1:53 ` David Miller
2013-01-23 2:32 ` Sanagi, Koki
2013-01-23 4:13 ` David Miller [this message]
2013-01-23 5:11 ` Sanagi, Koki
2013-01-23 5:21 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130122.231353.2100388787067184936.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sanagi.koki@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).