From: David Miller <davem@davemloft.net>
To: freddy@asix.com.tw
Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, louis@asix.com.tw
Subject: Re: [PATCH, resubmit] ax88179_178a: ASIX AX88179_178A USB 3.0/2.0 to gigabit ethernet adapter driver
Date: Tue, 22 Jan 2013 23:15:15 -0500 (EST) [thread overview]
Message-ID: <20130122.231515.1276077448591402095.davem@davemloft.net> (raw)
In-Reply-To: <1358908337-13841-1-git-send-email-freddy@asix.com.tw>
From: Freddy Xin <freddy@asix.com.tw>
Date: Wed, 23 Jan 2013 10:32:17 +0800
> Fixed coding style errors.
There are still many style issues remaining, you have a lot more
work to do, for example:
> + return fn(dev, cmd, USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE,
> + value, index, data, size);
> +
This empty line is unnecessary, get rid of it.
Also this function call is not indented properly. The first character
on the second line of the fn() call should line up with the first
column after the openning parenthesis of the first line of the call.
next prev parent reply other threads:[~2013-01-23 4:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-23 2:32 [PATCH, resubmit] ax88179_178a: ASIX AX88179_178A USB 3.0/2.0 to gigabit ethernet adapter driver Freddy Xin
2013-01-23 4:15 ` David Miller [this message]
2013-01-26 23:13 ` Michael Leun
2013-01-28 9:07 ` Bjørn Mork
2013-01-28 13:36 ` Freddy
2013-01-28 14:24 ` Bjørn Mork
2013-01-28 16:42 ` Michael Leun
-- strict thread matches above, loose matches on Subject: below --
2013-03-02 10:41 [PATCH " Freddy Xin
2013-03-03 6:44 ` David Miller
2013-02-27 12:01 Freddy Xin
2013-03-01 21:15 ` David Miller
2013-02-07 13:39 [PATCH, " Freddy Xin
2013-02-07 20:02 ` Ben Hutchings
2013-02-07 20:05 ` David Miller
2013-02-08 3:41 ` Freddy
2013-02-08 10:23 ` David Laight
2013-02-08 19:23 ` David Miller
2013-02-07 4:36 Freddy Xin
2013-02-07 5:45 ` Stephen Hemminger
[not found] ` <1360211794-4737-1-git-send-email-freddy-knRN6Y/kmf1NUHwG+Fw1Kw@public.gmane.org>
2013-02-07 5:46 ` Stephen Hemminger
2013-02-07 6:50 ` Freddy
2013-01-17 9:32 Freddy Xin
2013-01-18 19:23 ` David Miller
2013-01-18 20:29 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130122.231515.1276077448591402095.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=freddy@asix.com.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=louis@asix.com.tw \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).