From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH, resubmit] ax88179_178a: ASIX AX88179_178A USB 3.0/2.0 to gigabit ethernet adapter driver Date: Tue, 22 Jan 2013 23:15:15 -0500 (EST) Message-ID: <20130122.231515.1276077448591402095.davem@davemloft.net> References: <1358908337-13841-1-git-send-email-freddy@asix.com.tw> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, louis@asix.com.tw To: freddy@asix.com.tw Return-path: In-Reply-To: <1358908337-13841-1-git-send-email-freddy@asix.com.tw> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Freddy Xin Date: Wed, 23 Jan 2013 10:32:17 +0800 > Fixed coding style errors. There are still many style issues remaining, you have a lot more work to do, for example: > + return fn(dev, cmd, USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE, > + value, index, data, size); > + This empty line is unnecessary, get rid of it. Also this function call is not indented properly. The first character on the second line of the fn() call should line up with the first column after the openning parenthesis of the first line of the call.