From: Dan Carpenter <dan.carpenter@oracle.com>
To: Mark Einon <mark.einon@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, sfr@canb.auug.org.au,
davem@davemloft.net, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [RFC PATCH linux-next] et131x: Promote staging et131x driver to drivers/net
Date: Tue, 22 Jan 2013 09:20:10 +0300 [thread overview]
Message-ID: <20130122062010.GA16282@mwanda> (raw)
In-Reply-To: <CANK3SE2p3C38YrvCxWqvoRRz7=q7oAYyE=b0c7+ppBd3yzVrpw@mail.gmail.com>
On Mon, Jan 21, 2013 at 11:44:55PM +0000, Mark Einon wrote:
> On 19 January 2013 11:03, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> <snip>
> >
> > et131x_get_regs() has endian bugs calling et131x_mii_read().
> >
> </snip>
>
> Hi Dan,
>
> Could you be a bit more descriptive about the issues you think there
> are with these calls?
>
Sorry, that was sloppy on my part. Here's what I meant:
et131x_mii_read(adapter, MII_BMCR, (u16 *)®s_buff[num++]);
That puts the number in the 2 high bits which works for little
endian systems but not for big endian. It should be something like:
u16 tmp;
et131x_mii_read(adapter, MII_BMCR, &tmp);
regs_buff[num++] = tmp;
regards,
dan carpenter
next prev parent reply other threads:[~2013-01-22 6:20 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 20:40 [RFC PATCH linux-next] et131x: Promote staging et131x driver to drivers/net Mark Einon
2013-01-18 22:57 ` Greg KH
2013-01-19 11:03 ` Dan Carpenter
2013-01-19 11:48 ` [PATCH] staging: et131x: Fix all sparse warnings Mark Einon
2013-01-21 23:44 ` [RFC PATCH linux-next] et131x: Promote staging et131x driver to drivers/net Mark Einon
2013-01-22 6:20 ` Dan Carpenter [this message]
2013-01-23 10:10 ` [RFC PATCH v2 " Mark Einon
2013-01-23 10:31 ` Dan Carpenter
2013-01-23 11:31 ` Mark Einon
2013-01-23 12:45 ` [RFC PATCH v3 " Mark Einon
2013-01-23 14:32 ` Greg KH
2013-01-23 14:51 ` Mark Einon
2013-01-23 16:24 ` [RFC PATCH v4 " Mark Einon
2013-01-29 4:10 ` David Miller
2013-01-29 12:47 ` Mark Einon
-- strict thread matches above, loose matches on Subject: below --
2014-09-22 21:28 [RFC PATCH " Mark Einon
2014-09-22 23:56 ` Angus Gibson
2014-09-23 9:51 ` Mark Einon
2014-09-23 1:57 ` Joe Perches
2014-09-23 9:50 ` Mark Einon
2014-09-23 7:22 ` Tobias Klauser
2014-09-23 9:46 ` Mark Einon
2014-09-23 10:01 ` Tobias Klauser
2014-09-23 11:06 ` Mark Einon
2014-09-23 19:02 ` Francois Romieu
2014-09-23 19:17 ` Joe Perches
2014-09-23 20:07 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130122062010.GA16282@mwanda \
--to=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.einon@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).