From: David Miller <davem@davemloft.net>
To: kuznet@ms2.inr.ac.ru
Cc: avagin@openvz.org, netdev@vger.kernel.org, criu@openvz.org,
linux-kernel@vger.kernel.org, jmorris@namei.org,
yoshfuji@linux-ipv6.org, kaber@trash.net, edumazet@google.com,
ycheng@google.com, ncardwell@google.com, xemul@parallels.com,
davej@redhat.com, mtk.manpages@gmail.com
Subject: Re: [PATCH] [RFC] tcp: add ability to set a timestamp offset (v2)
Date: Wed, 23 Jan 2013 13:27:00 -0500 (EST) [thread overview]
Message-ID: <20130123.132700.188651787864830558.davem@davemloft.net> (raw)
In-Reply-To: <20130123162025.GA2147@ms2.inr.ac.ru>
From: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
Date: Wed, 23 Jan 2013 20:20:25 +0400
> Hello!
>
> On Wed, Jan 23, 2013 at 07:01:52PM +0400, Andrey Vagin wrote:
>> -#define tcp_time_stamp ((__u32)(jiffies))
>> +#define tcp_time_stamp(tp) ((__u32)(jiffies) + tp->tsoffset)
>
> This implies that you always have some tp in hands. AFAIK this is not true,
> so that I am puzzled how you were able to make something compilable with this definition.
>
> At least in tcp_v4_send_ack() you obviously use some invalid tp, there is
> no socket in hands there. The thing which is called "sk" is dummy.
>
> With container migration I used per-container offset. When you have no container,
> you have to do something a little bit smarter.
I'm starting to have almost no confidence in this change, and even the
basic conceptual idea behind it.
Please go back to the drawing board and really analyze this thing
completely rather than just bouncing broken patches to the list every
day.
Thanks.
prev parent reply other threads:[~2013-01-23 18:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-23 15:01 [PATCH] [RFC] tcp: add ability to set a timestamp offset (v2) Andrey Vagin
2013-01-23 15:01 ` [PATCH 1/2] tcp: make tcp_timestamp dependent on tcp_sock Andrey Vagin
2013-01-23 16:25 ` Eric Dumazet
2013-01-24 7:46 ` Andrew Vagin
2013-01-23 16:27 ` Christoph Paasch
2013-01-23 15:01 ` [PATCH 2/2] tcp: add ability to set a timestamp offset (v2) Andrey Vagin
2013-01-23 15:26 ` Pavel Emelyanov
2013-01-23 16:20 ` [PATCH] [RFC] " Alexey Kuznetsov
2013-01-23 18:27 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130123.132700.188651787864830558.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=avagin@openvz.org \
--cc=criu@openvz.org \
--cc=davej@redhat.com \
--cc=edumazet@google.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=xemul@parallels.com \
--cc=ycheng@google.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).