From: Timo Teras <timo.teras@iki.fi>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] r8169: remove the obsolete and incorrect AMD workaround
Date: Wed, 23 Jan 2013 08:14:08 +0200 [thread overview]
Message-ID: <20130123081408.2646fc4e@vostro> (raw)
In-Reply-To: <20130123000541.GA9515@electric-eye.fr.zoreil.com>
On Wed, 23 Jan 2013 01:05:41 +0100 Francois Romieu
<romieu@fr.zoreil.com> wrote:
> Timo Teräs <timo.teras@iki.fi> :
> [...]
>
> Acked-by: Francois Romieu <romieu@fr.zoreil.com>
>
> desc->opts2 is now a bit different in the RxRes path - the only path
> where the patch can be noticed. I hope it won't uncloak something
> else.
I was wondering what you mean by this. But as it seems
rtl8169_rx_vlan_tag() is doing opts2 = 0 in receive path. So the
only effect the workaround would have had was for the error path
packets.
So if this worries you, would it make sense to just unconditionally set
opts2 to zero also in the error path?
Actually, this sounds wrong. Why is rtl8169_rx_vlan_tag() which is
fiddling opts2 invoked *after* rtl8169_mark_to_asic() ? This means it
can overwrite the tag info if the queue is full.
- Timo
next prev parent reply other threads:[~2013-01-23 6:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-21 15:12 r8169 doing more work than napi weight Timo Teras
2013-01-21 23:42 ` Francois Romieu
2013-01-22 8:30 ` [PATCH net] r8169: remove the obsolete and incorrect AMD workaround Timo Teräs
2013-01-23 0:05 ` Francois Romieu
2013-01-23 0:42 ` David Miller
2013-01-23 6:14 ` Timo Teras [this message]
2013-01-23 22:38 ` Francois Romieu
2013-01-24 6:09 ` Timo Teras
2013-01-23 18:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130123081408.2646fc4e@vostro \
--to=timo.teras@iki.fi \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).