From: Steffen Klassert <steffen.klassert@secunet.com>
To: Tom Herbert <therbert@google.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
netdev@markandruth.co.uk, eric.dumazet@gmail.com
Subject: Re: [PATCH 2/5] soreuseport: TCP/IPv4 implementation
Date: Fri, 25 Jan 2013 09:08:11 +0100 [thread overview]
Message-ID: <20130125080811.GM9147@secunet.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1301221141310.26417@pokey.mtv.corp.google.com>
On Tue, Jan 22, 2013 at 11:50:24AM -0800, Tom Herbert wrote:
> - } else if (tb->fastreuse &&
> - (!sk->sk_reuse || sk->sk_state == TCP_LISTEN))
> - tb->fastreuse = 0;
> + if (sk->sk_reuseport) {
> + tb->fastreuseport = 1;
> + tb->fastuid = uid;
> + } else {
> + tb->fastreuseport = 0;
> + tb->fastuid = 0;
> + }
> + } else {
> + if (tb->fastreuse &&
> + (!sk->sk_reuse || sk->sk_state == TCP_LISTEN))
> + tb->fastreuse = 0;
> + if (tb->fastreuseport &&
> + (!sk->sk_reuseport || !uid_eq(tb->fastuid, uid))) {
> + tb->fastreuseport = 0;
> + tb->fastuid = 0;
> + }
I'm getting the following compile error due to the 0 assignment
to tb->fastuid:
net/ipv4/inet_connection_sock.c: In function ‘inet_csk_get_port’:
net/ipv4/inet_connection_sock.c:232:16: error: incompatible types when assigning to type ‘kuid_t’ from type ‘int’
net/ipv4/inet_connection_sock.c:241:16: error: incompatible types when assigning to type ‘kuid_t’ from type ‘int’
CC lib/show_mem.o
CC net/ipv6/ipv6_sockglue.o
make[3]: *** [net/ipv4/inet_connection_sock.o] Error 1
make[2]: *** [net/ipv4] Error 2
I have not seen this reported so far what surprises me a bit.
This is net-next from today complied with
gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3
next prev parent reply other threads:[~2013-01-25 8:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-22 19:50 [PATCH 2/5] soreuseport: TCP/IPv4 implementation Tom Herbert
2013-01-25 8:08 ` Steffen Klassert [this message]
2013-01-26 3:40 ` Tom Herbert
-- strict thread matches above, loose matches on Subject: below --
2013-01-14 20:00 Tom Herbert
2013-01-14 20:20 ` YOSHIFUJI Hideaki
2013-01-16 21:09 ` Vijay Subramanian
2013-01-16 21:10 ` David Miller
2013-01-16 21:30 ` Tom Herbert
2013-01-16 22:14 ` Vijay Subramanian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130125080811.GM9147@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@markandruth.co.uk \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).