From: Francois Romieu <romieu@fr.zoreil.com>
To: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com>
Cc: Frank Li <Frank.Li@freescale.com>,
lznuaa@gmail.com, shawn.guo@linaro.org, B38611@freescale.com,
davem@davemloft.net, linux-arm-kernel@lists.infradead.org,
netdev@vger.kernel.org, s.hauer@pengutronix.de
Subject: Re: [PATCH v3 1/1 net-next] net: fec: add napi support to improve proformance
Date: Fri, 25 Jan 2013 23:23:06 +0100 [thread overview]
Message-ID: <20130125222306.GA2523@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <20130125043311.GA4141@ppwaskie-mobl2.amr.corp.intel.com>
Waskiewicz Jr, Peter P <peter.p.waskiewicz.jr@intel.com> :
[...]
> Also, when you're disabling interrupts above, you're doing that in your
> HW interrupt handler, you should be using spin_lock_irqsave()/irq_restore().
Does the platform forbid to defer FEC_EIR / FEC_IEVENT write to the napi
poll handler and only disable the irq through FEC_EIMR / FEC_IMASK in
fec_enet_interrupt so as to remove the spinlock ?
(Frank, please keep an empty line between variables declarations and
function body).
--
Ueimor
next prev parent reply other threads:[~2013-01-25 22:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 1:29 [PATCH v3 1/1 net-next] net: fec: add napi support to improve proformance Frank Li
2013-01-25 4:33 ` Waskiewicz Jr, Peter P
2013-01-25 4:51 ` Frank Li
2013-01-25 22:23 ` Francois Romieu [this message]
2013-01-29 5:03 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130125222306.GA2523@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=B38611@freescale.com \
--cc=Frank.Li@freescale.com \
--cc=davem@davemloft.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lznuaa@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=s.hauer@pengutronix.de \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox