From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: greearb@candelatech.com, netdev@vger.kernel.org
Subject: Re: [PATCH] net: loopback: fix a dst refcounting issue
Date: Sun, 27 Jan 2013 19:26:38 -0500 (EST) [thread overview]
Message-ID: <20130127.192638.2227792070943381785.davem@davemloft.net> (raw)
In-Reply-To: <1359307508.5222.2226.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sun, 27 Jan 2013 09:25:08 -0800
> On Sun, 2013-01-27 at 01:32 -0500, David Miller wrote:
>
>> Applied, I suspect we need to tree wide audit for other instances of
>> this situation. Probably greps for skb_orphan() would be a good
>> start.
>
> I highly suspect macvlan needs a skb_dst_drop(), but couldnt trigger
> a case to trigger the fault.
I completely agree, when we hit the ->forward() or ->receive() method
we are leaving the RCU safety zone for the cached dst.
Even if you can't trigger it, this seems clear enough to me that we
should put those skb_dst_drop() calls in, so please formally submit
that patch you posted for Ben as an RFC last week.
Thanks.
prev parent reply other threads:[~2013-01-28 0:26 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-21 21:07 3.7.3+: Bad paging request in ip_rcv_finish while running NFS traffic Ben Greear
2013-01-22 0:32 ` Ben Greear
2013-01-22 4:40 ` Eric Dumazet
2013-01-22 5:57 ` Ben Greear
[not found] ` <50FE2A57.3040804-my8/4N5VtI7c+919tysfdA@public.gmane.org>
2013-01-22 17:08 ` Ben Greear
[not found] ` <50FEC796.5090404-my8/4N5VtI7c+919tysfdA@public.gmane.org>
2013-01-22 17:17 ` Eric Dumazet
2013-01-22 17:26 ` Ben Greear
2013-01-22 17:26 ` Eric Dumazet
2013-01-22 22:18 ` Ben Greear
[not found] ` <50FF102F.2050008-my8/4N5VtI7c+919tysfdA@public.gmane.org>
2013-01-23 2:32 ` Ben Greear
2013-01-23 6:11 ` Eric Dumazet
2013-01-23 7:14 ` Ben Greear
[not found] ` <50FF8DEC.9070901-my8/4N5VtI7c+919tysfdA@public.gmane.org>
2013-01-23 13:35 ` Eric Dumazet
2013-01-23 18:15 ` Ben Greear
2013-01-23 21:43 ` Eric Dumazet
2013-01-23 14:42 ` Eric Dumazet
2013-01-23 21:53 ` Ben Greear
[not found] ` <50FF4BC9.1060206-my8/4N5VtI7c+919tysfdA@public.gmane.org>
2013-01-23 23:55 ` Ben Greear
[not found] ` <5100785D.8040101-my8/4N5VtI7c+919tysfdA@public.gmane.org>
2013-01-24 0:01 ` Eric Dumazet
2013-01-24 0:13 ` Ben Greear
[not found] ` <51007CA8.2050105-my8/4N5VtI7c+919tysfdA@public.gmane.org>
2013-01-24 0:23 ` Eric Dumazet
2013-01-24 0:38 ` Ben Greear
2013-01-24 0:45 ` Eric Dumazet
2013-01-24 0:51 ` Ben Greear
2013-01-24 1:00 ` Eric Dumazet
2013-01-24 1:06 ` Ben Greear
2013-01-24 1:10 ` Eric Dumazet
2013-01-24 1:45 ` Eric Dumazet
2013-01-24 4:26 ` Ben Greear
2013-01-24 5:39 ` Eric Dumazet
2013-01-24 20:03 ` Ben Greear
2013-01-24 20:59 ` Eric Dumazet
2013-01-24 21:01 ` Ben Greear
2013-01-25 17:44 ` [PATCH] net: loopback: fix a dst refcounting issue Eric Dumazet
2013-01-27 6:32 ` David Miller
2013-01-27 17:25 ` Eric Dumazet
2013-01-28 0:26 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130127.192638.2227792070943381785.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=greearb@candelatech.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).