From: David Miller <davem@davemloft.net>
To: horms@verge.net.au
Cc: nobuhiro.iwamatsu.yj@renesas.com, netdev@vger.kernel.org,
linux-sh@vger.kernel.org
Subject: Re: [PATCH 2/2] net: sh-eth: Use pr_err instead of printk
Date: Sun, 27 Jan 2013 20:28:55 -0500 (EST) [thread overview]
Message-ID: <20130127.202855.2183638663551956921.davem@davemloft.net> (raw)
In-Reply-To: <20130128012640.GB27896@verge.net.au>
From: Simon Horman <horms@verge.net.au>
Date: Mon, 28 Jan 2013 10:26:40 +0900
> [Cc David Miller, linux-sh]
>
> On Tue, Oct 16, 2012 at 10:17:59AM +0900, Nobuhiro Iwamatsu wrote:
>> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
>
> Acked-by: Simon Horman <horms+renesas@verge.net.au>
>
> Dave, I know this is an oldie, but it appears to still be a goodie.
> Could you consider it for 3.8?
Why would I consider it for 3.8? We're in critical-but-fix-only
state and this just modifies kernel log messages in what should
be rare error paths, so entirely not appropriate for 3.8
next prev parent reply other threads:[~2013-01-28 1:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-16 1:17 [PATCH 1/2] net: sh_eth: Add support of device tree probe Nobuhiro Iwamatsu
2012-10-16 1:17 ` [PATCH 2/2] net: sh-eth: Use pr_err instead of printk Nobuhiro Iwamatsu
2013-01-28 1:26 ` Simon Horman
2013-01-28 1:28 ` David Miller [this message]
2013-01-28 1:41 ` Simon Horman
2013-01-28 1:21 ` [PATCH 1/2] net: sh_eth: Add support of device tree probe Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130127.202855.2183638663551956921.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=horms@verge.net.au \
--cc=linux-sh@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nobuhiro.iwamatsu.yj@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).