From: David Miller <davem@davemloft.net>
To: dan.carpenter@oracle.com
Cc: samuel@sortiz.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] irda: buffer overflow in irnet_ctrl_read()
Date: Sun, 27 Jan 2013 20:39:00 -0500 (EST) [thread overview]
Message-ID: <20130127.203900.315969902013911354.davem@davemloft.net> (raw)
In-Reply-To: <20130125064056.GA4882@elgon.mountain>
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 25 Jan 2013 09:40:56 +0300
> The comments here say that the /* Max event is 61 char */ but in 2003 we
> changed the event format and now the max event size is 75. The longest
> event is:
>
> "Discovered %08x (%s) behind %08x {hints %02X-%02X}\n",
> 12345678901 23 456789012 34567890 1 2 3
> +8 +21 +8 +2 +2 +1
> = 75 characters.
>
> There was a check to return -EOVERFLOW if the user gave us a "count"
> value that was less than 64. Raising it to 75 might break backwards
> compatability. Instead I removed the check and now it returns a
> truncated string if "count" is too low.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied to net-next, thanks.
prev parent reply other threads:[~2013-01-28 1:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 6:40 [patch] irda: buffer overflow in irnet_ctrl_read() Dan Carpenter
2013-01-28 1:39 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130127.203900.315969902013911354.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=samuel@sortiz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).